You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- This project uses yarn/berry, so you will need to install it, preferably by enabling corepack:
22
+
23
+
```
24
+
corepack enable
25
+
```
22
26
23
27
#### Useful Commands:
24
28
25
-
- Install project dependencies: `pnpm install`
26
-
- Compile the packages `pnpm run compile`
27
-
- Watch the packages for changes and recompile: `pnpm run start` (You need to run this command in the package subfolder you are updating)
28
-
- Run `docker-compose up -d` to start database services required for tests.
29
-
- Run `pnpm run test` to run all the tests.
29
+
- Install project dependencies: `yarn install`
30
+
- Compile the packages `yarn run compile`
31
+
- Watch the packages for changes and recompile: `yarn workspace @accounts/packagename run start`
32
+
- Run `dockercompose up -d` to start database services required for tests.
33
+
- Run `yarn run test` to run all the tests (`yarn workspace @accounts/packagename run test` to run tests for a certain package).
30
34
31
35
## Pull Requests
32
36
@@ -37,15 +41,15 @@ Alternatively, prepend your PR title with `[discuss]` to have a conversation aro
37
41
38
42
#### All PRs:
39
43
40
-
1. Must not break the **test suite** (`pnpm run test`), nor reduce **test coverage** (`pnpm run coverage`). If you're fixing a bug, include a test that would fail without your fix.
44
+
1. Must not break the **test suite** (`yarn run test`), nor reduce **test coverage** (`yarn run coverage`). If you're fixing a bug, include a test that would fail without your fix. Also ensure that **all** examples still work as expected.
41
45
42
-
2. Must respect the **.eslintrc.js** (`pnpm run test:lint`). Ideally your editor supports `eslint`. Especially since the project is quite new, feel free to query default rules with us that don't make sense, or disable rules in a particular scope when it makes sense, together with a comment explaining why.
46
+
2. Must respect the **.eslintrc.js** (`yarn run test:lint`). Ideally your editor supports `eslint`. Especially since the project is quite new, feel free to query default rules with us that don't make sense, or disable rules in a particular scope when it makes sense, together with a comment explaining why.
43
47
44
48
3. Must be **isolated**. Avoid grouping many, unrelated changes in a single PR.
45
49
46
50
4. GitHub now allows auto-squashing of commits in a PR, so no need to rebase your commits before final submission.
47
51
48
-
5. Must contain a changeset file describing the changes and affected packages. Run `pnpx changeset` to generate one.
52
+
5. Must contain a changeset file describing the changes and affected packages. Run `yarn changeset` to generate one.
0 commit comments