-
-
Notifications
You must be signed in to change notification settings - Fork 625
Basic Packagedcode module for handling Rust's cargo crates #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Packagedcode module for handling Rust's cargo crates #1426
Conversation
Signed-off-by: Ritiek Malhotra <[email protected]>
Signed-off-by: Ritiek Malhotra <[email protected]>
Signed-off-by: Ritiek Malhotra <[email protected]>
|
Also see #1424. |
|
For those looking to quickly test this out. Clone any Rust repository and run scancode on it: |
Codecov Report
@@ Coverage Diff @@
## develop #1426 +/- ##
===========================================
- Coverage 83.84% 83.81% -0.03%
===========================================
Files 119 120 +1
Lines 14041 14091 +50
===========================================
+ Hits 11772 11810 +38
- Misses 2269 2281 +12
Continue to review full report at Codecov.
|
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ++ this is looking very good!
🙇♂️
Signed-off-by: Ritiek Malhotra <[email protected]>
Signed-off-by: Ritiek Malhotra <[email protected]>
|
I've added some tests as well. This should be ready to merge if everything looks good. I think we could extend the subclass for handling more |
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looking good.
Thanks ++
Merging now.
| "thirdparty/text_unidecode-1.2-py2.py3-none-any.whl", | ||
| "thirdparty/text_unidecode-1.2-py2.py3-none-any.whl.ABOUT", | ||
| "thirdparty/text_unidecode-1.2-py2.py3-none-any.whl.NOTICE", | ||
| "thirdparty/toml-0.10.0-py2.py3-none-any.whl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not your making but this is a weird test that I will need to fix.
A very basic implementation at the moment. This is still missing tests which I'll add in shortly.
Otherwise, this is ready for review!