fix: host.isKnownTypesPackageName maybe undefined (microsoft#42050)

chenjigeng · Zzzen · commit 22fa1569f3d3 · 2021-01-16T22:40:43.000+08:00
* fix: host.isKnownTypesPackageName maybe undefined

* feat: remove GH#18217 comment
diff --git a/src/services/codefixes/fixCannotFindModule.ts b/src/services/codefixes/fixCannotFindModule.ts
@@ -52,6 +52,6 @@ namespace ts.codefix {
     function getTypesPackageNameToInstall(packageName: string, host: LanguageServiceHost, diagCode: number): string | undefined {
         return diagCode === errorCodeCannotFindModule
             ? (JsTyping.nodeCoreModules.has(packageName) ? "@types/node" : undefined)
-            : (host.isKnownTypesPackageName!(packageName) ? getTypesPackageName(packageName) : undefined); // TODO: GH#18217
+            : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,6 @@ namespace ts.codefix {`
`52`	`52`	`function getTypesPackageNameToInstall(packageName: string, host: LanguageServiceHost, diagCode: number): string \| undefined {`
`53`	`53`	`return diagCode === errorCodeCannotFindModule`
`54`	`54`	`? (JsTyping.nodeCoreModules.has(packageName) ? "@types/node" : undefined)`
`55`		`- : (host.isKnownTypesPackageName!(packageName) ? getTypesPackageName(packageName) : undefined); // TODO: GH#18217`
	`55`	`+ : (host.isKnownTypesPackageName?.(packageName) ? getTypesPackageName(packageName) : undefined);`
`56`	`56`	`}`
`57`	`57`	`}`