Skip to content

TypeScript 2.4 string enums #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benny-medflyt opened this issue Jun 22, 2017 · 5 comments · Fixed by #147
Closed

TypeScript 2.4 string enums #128

benny-medflyt opened this issue Jun 22, 2017 · 5 comments · Fixed by #147

Comments

@benny-medflyt
Copy link
Contributor

TypeScript 2.4 will have string enums:
https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#string-enums

Any plans to support this?

thank you

@domoritz
Copy link
Collaborator

domoritz commented Jun 23, 2017

What errors are you getting? I think this is an awesome feature.

I'm focusing on adding all the latest features to https://github.com/vega/typescript-to-json-schema but I'm happy to review pull requests.

@benny-medflyt
Copy link
Contributor Author

  1. I haven't actually tried yet to use typescript 2.4 and string enums with typescript-json-schema 😮 . I will give it a whirl soon when I have some time and report back.

  2. Is https://github.com/vega/typescript-to-json-schema going to be the successor to https://github.com/YousefED/typescript-json-schema ? Which one should new projects use?

thank you

@domoritz
Copy link
Collaborator

Just added ts 2.4 support to https://github.com/vega/typescript-to-json-schema.

Is https://github.com/vega/typescript-to-json-schema going to be the successor to https://github.com/YousefED/typescript-json-schema ? Which one should new projects use?

Maybe, maybe not. I have shifted my attention towards the other one because I needed support for proper aliasing. Howver, I decided not to port a lot of features that exist here. I think both libraries ave their place and hopefully it's easy to switch from one to the other.

I suggest that you try both and see whether theyr support the features you need and produce clean output for your code.

@amcdnl
Copy link

amcdnl commented Jul 28, 2017

@domoritz - any chance of adding TS 2.4 support for this project? I'm wanting to use the string enums too.

@domoritz
Copy link
Collaborator

I won't do it for a few months but I can review PRs. Until then, give https://github.com/vega/typescript-to-json-schema a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants