Skip to content

Commit 2914187

Browse files
Turn on strong mode for integrate directory
1 parent af8d5f9 commit 2914187

8 files changed

+461
-23
lines changed

.analysis_options

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
analyzer:
22
strong-mode: true
3-
exclude:
4-
- integrate/**
53
linter:
64
rules:
75
- annotate_overrides

integrate/lib/test_component_declaration.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414

1515
library test_component_declaration;
1616

17-
import 'package:over_react/ui_core.dart';
18-
import 'package:over_react/ui_components.dart';
17+
import 'package:over_react/over_react.dart';
1918

2019
@Factory()
2120
UiFactory<FooProps> Foo;
@@ -30,7 +29,7 @@ class FooState extends UiState {}
3029
class FooComponent extends UiStatefulComponent<FooProps, FooState> {
3130
@override
3231
render() {
33-
return Button()(
32+
return Dom.div()(
3433
'Child 1',
3534
'Child 2'
3635
);

integrate/lib/test_react_element_typing.dart

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,14 @@ import './test_component_declaration.dart';
2020

2121
/// Verify that treating the invocation of the builder as an unparameterized [ReactElement]
2222
/// does not result in the following analyzer warning:
23-
/// > Unsound implicit cast from ReactElement<dynamic> to ReactElement<Component>
24-
void _reactElementTypingTest() {
23+
///
24+
/// Unsound implicit cast from ReactElement<dynamic> to ReactElement<Component>
25+
ReactElement _reactElementTypingTest() {
2526
ReactElement element = Foo()();
27+
28+
return element;
29+
}
30+
31+
main() {
32+
_reactElementTypingTest();
2633
}

0 commit comments

Comments
 (0)