Properly exclude steps

Author: lpardosixtosMs

experimental/javascript-wc-indexeddb/dist/src/components/todo-list/todo-list.component.js

@@ -130,7 +130,6 @@ class TodoList extends HTMLElement {
     }
 
     moveToNextPage() {
-        console.log("number of children before removing:", this.listNode.children.length);
         for (let i = 0; i < MAX_ON_SCREEN_ITEMS; i++) {
             const child = this.listNode.firstChild;
             if (!child)

experimental/javascript-wc-indexeddb/dist/src/speedometer-utils/benchmark.mjs

@@ -8,9 +8,10 @@ import { Params } from "./params.mjs";
  * A single test step, with a common interface to interact with.
  */
 export class BenchmarkStep {
-    constructor(name, run) {
+    constructor(name, run, ignoreResult = false) {
         this.name = name;
         this.run = run;
+        this.ignoreResult = ignoreResult;
     }
 
     async runAndRecord(params, suite, test, callback) {
@@ -106,6 +107,7 @@ export class BenchmarkConnector {
                 if (!suite)
                     console.error(`Suite with the name of "${event.data.name}" not found!`);
                 const { result } = await suite.runAndRecord(params, (test) => this.sendMessage({ type: "step-complete", status: "success", appId: this.appId, name: this.name, test }));
+                console.log(result, result.tests);
                 this.sendMessage({ type: "suite-complete", status: "success", appId: this.appId, result });
                 this.disconnect();
                 break;

experimental/javascript-wc-indexeddb/dist/src/storage/storage-factory.js

@@ -7,7 +7,6 @@ import DexieDBManager from "./dexieDB-manager.js";
  */
 export function createStorageManager() {
     const params = new URLSearchParams(window.location.search);
-    console.log("URLSearchParams:", params.toString());
     let storageType = params.get("storageType");
     if (storageType && storageType !== "vanilla" && storageType !== "dexie")
         throw new Error(`Invalid storage type specified in URL parameter: ${storageType}`);

experimental/javascript-wc-indexeddb/dist/src/workload-test.mjs

@@ -35,7 +35,6 @@ const suites = {
                 }
                 if (j < 9) {
                     const nextPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".next-page-button");
-                    console.log("Clicking next page button", j);
                     nextPageButton.click();
                 }
             }

experimental/javascript-wc-indexeddb/src/components/todo-list/todo-list.component.js

@@ -130,7 +130,6 @@ class TodoList extends HTMLElement {
     }
 
     moveToNextPage() {
-        console.log("number of children before removing:", this.listNode.children.length);
         for (let i = 0; i < MAX_ON_SCREEN_ITEMS; i++) {
             const child = this.listNode.firstChild;
             if (!child)

experimental/javascript-wc-indexeddb/src/speedometer-utils/benchmark.mjs

@@ -8,9 +8,10 @@ import { Params } from "./params.mjs";
  * A single test step, with a common interface to interact with.
  */
 export class BenchmarkStep {
-    constructor(name, run) {
+    constructor(name, run, ignoreResult = false) {
         this.name = name;
         this.run = run;
+        this.ignoreResult = ignoreResult;
     }
 
     async runAndRecord(params, suite, test, callback) {
@@ -106,6 +107,7 @@ export class BenchmarkConnector {
                 if (!suite)
                     console.error(`Suite with the name of "${event.data.name}" not found!`);
                 const { result } = await suite.runAndRecord(params, (test) => this.sendMessage({ type: "step-complete", status: "success", appId: this.appId, name: this.name, test }));
+                console.log(result, result.tests);
                 this.sendMessage({ type: "suite-complete", status: "success", appId: this.appId, result });
                 this.disconnect();
                 break;

experimental/javascript-wc-indexeddb/src/storage/storage-factory.js

@@ -7,7 +7,6 @@ import DexieDBManager from "./dexieDB-manager.js";
  */
 export function createStorageManager() {
     const params = new URLSearchParams(window.location.search);
-    console.log("URLSearchParams:", params.toString());
     let storageType = params.get("storageType");
     if (storageType && storageType !== "vanilla" && storageType !== "dexie")
         throw new Error(`Invalid storage type specified in URL parameter: ${storageType}`);

experimental/javascript-wc-indexeddb/src/workload-test.mjs

@@ -35,7 +35,6 @@ const suites = {
                 }
                 if (j < 9) {
                     const nextPageButton = document.querySelector("todo-app").shadowRoot.querySelector("todo-bottombar").shadowRoot.querySelector(".next-page-button");
-                    console.log("Clicking next page button", j);
                     nextPageButton.click();
                 }
             }

resources/benchmark-runner.mjs

@@ -6,10 +6,9 @@ import { SUITE_RUNNER_LOOKUP } from "./suite-runner.mjs";
 const performance = globalThis.performance;
 
 export class BenchmarkTestStep {
-    constructor(testName, testFunction, ignoreResult = false) {
+    constructor(testName, testFunction) {
         this.name = testName;
         this.run = testFunction;
-        this.ignoreResult = ignoreResult;
     }
 }
 

resources/suite-runner.mjs

@@ -12,7 +12,6 @@ export class SuiteRunner {
 
     constructor(frame, page, params, suite, client, measuredValues) {
         // FIXME: Create SuiteRunner-local measuredValues.
-        console.log("Params", params);
         this.#suiteResults = measuredValues.tests[suite.name];
         if (!this.#suiteResults) {
             this.#suiteResults = { tests: {}, prepare: 0, total: 0 };
@@ -116,10 +115,6 @@ export class SuiteRunner {
         if (this.#suite === WarmupSuite)
             return;
 
-        // Skip recording results if the test step has ignoreResult flag set to true
-        if (test.ignoreResult)
-            return;
-
         let total = syncTime + asyncTime;
         this.#suiteResults.tests[test.name] = {
             tests: { Sync: syncTime, Async: asyncTime },