-
Notifications
You must be signed in to change notification settings - Fork 98
Fill in CanonicalABI.md #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
41d8902
Fill in CanonicalABI.md (based on interface-types/#140)
lukewagner 62f8fb8
Add dynamic alignment checks to load and store
lukewagner 34db917
Split out separate canonicalize32/64 so there is an explicit float32 …
lukewagner fe03324
Sync CanonicalABI.md
lukewagner cb5259c
Add comment for pack/unpack usage
lukewagner 7a2ee91
Add NaN canonicalization explanation
lukewagner 26aa846
Canonicalize before storing/lowering to make it clear which bit patte…
lukewagner 6a00372
Add string encoding links and reword string paragraph so they show up…
lukewagner da5d058
Fix text about multi-value limitation
lukewagner b52a78c
Add blurb about defaults-to in Explainer.md
lukewagner 4035e4e
Sync CanonicalABI.md with definitions.py
lukewagner 5679ffb
Pass string length in code units, not bytes, and fix string realloc a…
lukewagner 171e706
Merge elem_size and byte_size into size
lukewagner 32f8a0c
Add GitHub Actions workflow to test canonical abi
alexcrichton 838e063
Merge pull request #24 from alexcrichton/actions-test
fitzgen 6d77ea9
Make byte-to-bool conversion trap if greater than 1
lukewagner 4bf614e
Add + to enum/union to match the other places
lukewagner 5e438f4
Pass the return values to the post-return function
lukewagner 62524b7
Fix typos
lukewagner 818e6d3
Add NaN canonicalization tests
lukewagner bf73065
Sync CanonicalABI.md with canonical-abi/definitions.py
lukewagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| canonical_abi: | ||
| name: Run Canonical ABI Tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '>= 3.10.0' | ||
| - run: python design/mvp/canonical-abi/run_tests.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.