fix: fix text decoration change when on visual mode #9840
+40
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not in insert mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When selecting a word like
getDatausingviw->visual mode, the last character becomes hard to see in dark mode due to the current text-decoration styling. This PR fixes that visibility issue so the full selection is clearly readable.Which issue(s) this PR fixes
This PR solve the last character visibility issue shows in https://cloud.githubusercontent.com/assets/2787987/24952577/7ab97fee-1faa-11e7-81aa-80bfc0da7bbc.png
Special notes for your reviewer:
Open to any feedback or improvements 😊