UI updates #159
Open
UI updates #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x text to settings, general clean up
deece
reviewed
Feb 20, 2019
deece
left a comment
deece
left a comment
There was a problem hiding this comment.
A number of files have seen unnecessary permissions changes. These should be resolved to make life easier for the project maintainers.
| <externalSettings/> | ||
| <extensions> | ||
| <extension id="org.eclipse.cdt.core.ELF" point="org.eclipse.cdt.core.BinaryParser"/> | ||
| <extension id="org.eclipse.cdt.core.GNU_ELF" point="org.eclipse.cdt.core.BinaryParser"/> |
There was a problem hiding this comment.
These (and other project changes) are likely not necessary.
Author
There was a problem hiding this comment.
Ok thanks I'll resolve these issues before making another pull request.
| ============================== | ||
| Custom firmware for the cheap T-962 reflow oven utilizing the _existing_ controller hardware. | ||
| This project is a fork of the original Unified Engineering firmware for the T-962 reflow oven. This version primarily changes the UI, as I wanted something a little more aesthetic. I added a pre-built .hex file to make it simple to update an oven without needing to install an IDE to build it! | ||
|
|
There was a problem hiding this comment.
This doesn't make sense to contribute back to the parent project.
| [Flashing firmware]: https://github.com/UnifiedEngineering/T-962-improvements/wiki/Flashing-the-LPC21xx-controller | ||
| [DS18B20]: http://datasheets.maximintegrated.com/en/ds/DS18B20.pdf | ||
| [hackaday post]: http://hackaday.com/2014/11/27/improving-the-t-962-reflow-oven/ | ||
| Quick video of updated UI here: [https://www.youtube.com/watch?v=ooQ-jpgfutc] (Youtube video) |
| Y >>= 3; | ||
|
|
||
| #ifndef MINIMALISTIC | ||
| //#ifndef MINIMALISTIC |
There was a problem hiding this comment.
Is this obsolete? If so, it should be removed rather than commented out.
| #define FB_HEIGHT (64) | ||
| #define FB_WIDTH (128) | ||
| #define FB_HEIGHT (64) | ||
| #define FB_WIDTH (128) |
There was a problem hiding this comment.
Whitespace changes probably shouldn't be pushed back, unless they are part of a cleanup patch.
| REFLOW_MIN_FAN_SPEED, | ||
| REFLOW_BAKE_SETPOINT_H, | ||
| REFLOW_BAKE_SETPOINT_L, | ||
|
|
|
|
||
| LCD_BMPDisplay(stopbmp, 127 - 17, 0); | ||
|
|
||
|
|
…tays on display after reflow ends, for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first time making a pull request on here, so be gentle! I've been posting videos of my updates on Instagram, and users asked me to see if the changes could be added to the main branch.
This branch has a lot of changes to the UI including:
Animated titles, alignment of elements on all screens, important elements now flash
Changes to all bmp files to add continuity
Ability to switch between normal reflow graph and simplified "big number" version while reflowing
Both reflow screens now flash set temp/act temp if they are over 5 degrees apart
Reflow edit screens now use crosshairs, and show m:s and temp at top for each set point.
Splash screen change (Unified Engineering still displayed in About screen)
Settings screen can now scroll if over 6 items. Also has custom text per item when at min/max settings
Screensaver can be set in settings screen, this shows an animated "Pacman" type display while unit idle
I've kept most changes in a few new include files. No changes to reflow/serial functionality.