-
Notifications
You must be signed in to change notification settings - Fork 75
Update docs & breaking changes for specVersion: 3.0 #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
matz3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok from my side
flovogt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Günter Klatt <[email protected]>
Co-authored-by: Günter Klatt <[email protected]>
KlattG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's adjust to use relative, not absolute links, wherever possible.
Done. |
flovogt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KlattG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use 'please' very sparingly in documentation, i.e. only where we ask the user to do something unusually complex or tedious. Otherwise, I'd omit it.
BREAKING CHANGE: Installers and Resolvers' argument `ui5HomeDir` is now renamed to `ui5DataDir` JIRA: CPOUI5FOUNDATION-802 Relates to: #701
JIRA: CPOUI5FOUNDATION-473