Skip to content

Conversation

@d3xter666
Copy link
Member

JIRA: CPOUI5FOUNDATION-473

matz3
matz3 previously requested changes Dec 12, 2022
@d3xter666 d3xter666 requested a review from matz3 December 13, 2022 14:15
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok from my side

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt requested a review from KlattG December 15, 2022 09:43
d3xter666 and others added 2 commits December 16, 2022 10:50
@d3xter666 d3xter666 requested a review from KlattG December 16, 2022 08:51
KlattG
KlattG previously approved these changes Dec 16, 2022
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ecker
ecker previously requested changes Dec 21, 2022
Copy link
Contributor

@ecker ecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's adjust to use relative, not absolute links, wherever possible.

@d3xter666
Copy link
Member Author

Let's adjust to use relative, not absolute links, wherever possible.

Done.
This one should stay https://github.com/SAP/ui5-tooling/blame/main/docs/pages/Configuration.md#L11
because it shows the full URL of the schema and would never change. If we change it, then the schema.org integration would stop working

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt requested a review from ecker December 21, 2022 12:29
@flovogt flovogt dismissed stale reviews from ecker and RandomByte December 21, 2022 12:30

done

@d3xter666 d3xter666 merged commit a786410 into main Dec 21, 2022
@d3xter666 d3xter666 deleted the specVersion-3.0 branch December 21, 2022 12:47
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use 'please' very sparingly in documentation, i.e. only where we ask the user to do something unusually complex or tedious. Otherwise, I'd omit it.

d3xter666 added a commit that referenced this pull request Sep 24, 2025
BREAKING CHANGE:
Installers and Resolvers' argument `ui5HomeDir` is now renamed to
`ui5DataDir`

JIRA: CPOUI5FOUNDATION-802
Relates to: #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants