Skip to content

Option tslintAutoFix is broken for vue file #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mortyccp opened this issue Dec 21, 2018 · 4 comments
Closed

Option tslintAutoFix is broken for vue file #191

mortyccp opened this issue Dec 21, 2018 · 4 comments
Labels

Comments

@mortyccp
Copy link

mortyccp commented Dec 21, 2018

Step to reproduce

  1. git clone https://github.com/mortyccp/reproduces
  2. cd reproduces
  3. git checkout fork-ts-checker-autofix-vue
  4. Follow instruction defined in the readme in the cloned repo.
@Bosee
Copy link

Bosee commented Jan 7, 2019

same issue too, all vue files was broken when tslint auto-fix enabled

@johnnyreilly
Copy link
Member

If someone could take a look at this that'd be great!

Perhaps @ajainarayanan could advise? I'm not a Vue user I'm afraid.

@ajainarayanan
Copy link
Contributor

I have not worked with vue before. But enabling tslintAutoFix literally just passes on the --autofix flag to tslint. I don't think this error is related to fork-ts-checker-webpack-plugin

BTW @mortyccp I tried cloning your repo and ran yarn serve setting the tslintAutoFix to both true and false in vue.config.js. Either ways I am getting the same error in the console. Are you sure if this was working before you changed the tslintAutoFix flag?

@mortyccp
Copy link
Author

mortyccp commented Jan 8, 2019

@ajainarayanan Sorry, I mistakenly commit the files in after state. You can just git diff HEAD~ to see the change on those files then.
I have pushed a commit and it should be able to reproduce now.
The src/App.vue contins code, import Vue from "vue"; , violating the quotemark rule and trigger the auto fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants