test: add regression tests for #267, #299, #300

Author: phryneas

package.json

@@ -114,6 +114,7 @@
     "@types/babel-code-frame": "^6.20.1",
     "@types/chokidar": "^1.7.5",
     "@types/jest": "^24.0.11",
+    "@types/lodash": "^4.14.134",
     "@types/micromatch": "^3.1.0",
     "@types/minimatch": "^3.0.1",
     "@types/mock-require": "^2.0.0",
@@ -130,6 +131,7 @@
     "istanbul": "^0.4.5",
     "jest": "^24.7.1",
     "lint-staged": "^8.0.5",
+    "lodash": "^4.17.11",
     "mock-fs": "^4.3.0",
     "mock-require": "^3.0.2",
     "prettier": "^1.14.3",

test/integration/general.spec.ts

@@ -1,7 +1,9 @@
+// tslint:disable: no-implicit-dependencies - tests might also use devDependencies
 import fs from 'fs';
 import path from 'path';
 import ForkTsCheckerWebpackPlugin from '../../lib/index';
 import * as helpers from './helpers';
+import { cloneDeep } from 'lodash';
 
 describe.each([[true], [false]])(
   '[INTEGRATION] common tests - useTypescriptIncrementalApi: %s',
@@ -473,5 +475,49 @@ describe.each([[true], [false]])(
         callback();
       });
     });
+
+    /**
+     * regression test for #267, #299
+     */
+    it('should work even when the plugin has been deep-cloned', callback => {
+      const compiler = createCompiler({
+        pluginOptions: {
+          tsconfig: 'tsconfig-semantic-error-only.json'
+        },
+        prepareWebpackConfig({ plugins, ...config }) {
+          return { ...config, plugins: cloneDeep(plugins) };
+        }
+      });
+
+      compiler.run((err, stats) => {
+        expect(stats.compilation.errors).toEqual([
+          expect.objectContaining({
+            message: expect.stringContaining('TS2322')
+          })
+        ]);
+        callback();
+      });
+    });
+
+    /**
+     * regression test for #300
+     */
+    it('should work when `path` is set with relative paths', callback => {
+      const compiler = createCompiler({
+        pluginOptions: {
+          tsconfig: 'tsconfig-semantic-error-only.json',
+          watch: ['./test1', './test2']
+        }
+      });
+
+      compiler.run((err, stats) => {
+        expect(stats.compilation.errors).toEqual([
+          expect.objectContaining({
+            message: expect.stringContaining('TS2322')
+          })
+        ]);
+        callback();
+      });
+    });
   }
 );

yarn.lock

@@ -1159,6 +1159,11 @@
   dependencies:
     "@types/jest-diff" "*"
 
+"@types/lodash@^4.14.134":
+  version "4.14.134"
+  resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.134.tgz#9032b440122db3a2a56200e91191996161dde5b9"
+  integrity sha512-2/O0khFUCFeDlbi7sZ7ZFRCcT812fAeOLm7Ev4KbwASkZ575TDrDcY7YyaoHdTOzKcNbfiwLYZqPmoC4wadrsw==
+
 "@types/micromatch@^3.1.0":
   version "3.1.0"
   resolved "https://registry.yarnpkg.com/@types/micromatch/-/micromatch-3.1.0.tgz#514c8a3d24b2680a9b838eeb80e6d7d724545433"