Using import completion results in import removing prefixed whitespace

[blakeembrey]

Sometimes you want/need whitespace - E.g. writing an ambient module definition manually.

[basarat]

Guidance

This code :

atom-typescript/lib/main/atom/autoCompleteProvider.ts

Lines 201 to 240 in 9a5c29f

	onDidInsertSuggestion: (options) => {
	if (options.suggestion.atomTS_IsReference
	|| options.suggestion.atomTS_IsImport
	|| options.suggestion.atomTS_IsES6Import) {
	// '' implies we will preserve their quote character
	var quote = (/["']/.exec(atomConfig.preferredQuoteCharacter) || [''])[0];
	if (options.suggestion.atomTS_IsReference) {
	options.editor.moveToBeginningOfLine();
	options.editor.selectToEndOfLine();
	options.editor.replaceSelectedText(null, function() { return '/// <reference path="' + options.suggestion.atomTS_IsReference.relativePath + '.ts"/>'; });
	}
	if (options.suggestion.atomTS_IsImport) {
	options.editor.moveToBeginningOfLine();
	options.editor.selectToEndOfLine();
	var groups = /^\s*import\s*(\w*)\s*=\s*require\s*\(\s*(["'])/.exec(options.editor.getSelectedText());
	var alias = groups[1];
	// Use the option if they have a preferred. Otherwise preserve
	quote = quote || groups[2];
	options.editor.replaceSelectedText(null, function() { return `import ${alias} = require(${quote}${options.suggestion.atomTS_IsImport.relativePath}${quote});`; });
	}
	if (options.suggestion.atomTS_IsES6Import) {
	var {row} = options.editor.getCursorBufferPosition();
	var originalText = (<any>options.editor).lineTextForBufferRow(row);
	var groups = /(.*)from\s*(["'])/.exec(originalText);
	var beforeFrom = groups[1];
	// Use the option if they have a preferred. Otherwise preserve
	quote = quote || groups[2];
	var newTextAfterFrom = `from ${quote}${options.suggestion.atomTS_IsES6Import.relativePath}${quote};`;
	options.editor.setTextInBufferRange([[row, beforeFrom.length], [row, originalText.length]], newTextAfterFrom)
	}
	options.editor.moveToEndOfLine();
	}
	}

should preserve whitespace 🌹

@blakeembrey Label as up for grabs if want it open for someone else 🌹

[austingreendev]

@blakeembrey I would be willing to take a stab at this one if you want to assignee the issue to me. I've been using this tool for quite a while so I'm looking to give back!

[blakeembrey]

@Austin94 We can't assign issues to people outside the organisation (I know, it'd be cool for GitHub to maybe allow this) but it's all yours if you're willing to work on it! Thank you 👍

[austingreendev]

@blakeembrey Just made pull request #805. Let me know what you think.

[basarat]

Fixed with #805 🌹 Released https://github.com/TypeStrong/atom-typescript/releases/tag/v7.16.1