Skip to content

Syntax Highlighting not working for function shorthand in objects #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zimme opened this issue Nov 5, 2015 · 4 comments
Closed

Syntax Highlighting not working for function shorthand in objects #707

zimme opened this issue Nov 5, 2015 · 4 comments

Comments

@zimme
Copy link

zimme commented Nov 5, 2015

callSomeFunctionWithOptions({
  // function not highlighted
  callback(error, result): void {
    ...
  }
});

callSomeFunctionWithOptions({
  // function highlighted
  callback: function callback(error, result): void {
    ...
  }
});
@basarat
Copy link
Member

basarat commented Nov 6, 2015

Verified bug:

let foo = {
    // not highlighted
    callback(error, result): void {
    }
}

let bar = {
    // function highlighted
    callback: function callback(error, result): void {
    }
}

image

@quadrophobiac
Copy link

Hi there, I'm interested in picking up this bug to work on. I've developed on Electron in the past (most recent PR here theodi/comma-chameleon#76) and hacked away at Atom getting a few personal workflows in place. Can I proceed on working on this?

@basarat
Copy link
Member

basarat commented Nov 10, 2015

@quadrophobiac any effort in grammar should go to : #675 🌹

@basarat
Copy link
Member

basarat commented Jan 12, 2016

@basarat basarat closed this as completed Jan 12, 2016
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants