Skip to content

syntax highlighting fails for optional function arguments #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
psnider opened this issue Oct 17, 2015 · 2 comments
Closed

syntax highlighting fails for optional function arguments #667

psnider opened this issue Oct 17, 2015 · 2 comments
Labels
bug category:grammar up-for-grabs

Comments

@psnider
Copy link

psnider commented Oct 17, 2015

Similar to #395?

The declaration in the first line has proper syntax highlighting,
...while adding a question mark in the second line removes highlighting
and the highlighting on the next line is incorrect (type is misrecognized)

ts highlight opt args bug

This also seems to affect much of the following highlighting.
@basarat
Copy link
Member

basarat commented Nov 10, 2015

any effort in grammar should go to #675 🌹

@basarat
Copy link
Member

basarat commented Jan 12, 2016

Should work with release https://github.com/TypeStrong/atom-typescript/releases/tag/v8.0.0 🌹 If not raise issue at https://github.com/Microsoft/TypeScript-TmLanguage/issues and link us 🌹

@basarat basarat closed this as completed Jan 12, 2016
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug category:grammar up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@basarat @psnider