Skip to content

allowJs and checkJs config #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrobinson01 opened this issue Nov 15, 2018 · 2 comments · Fixed by #1456
Closed

allowJs and checkJs config #1467

jrobinson01 opened this issue Nov 15, 2018 · 2 comments · Fixed by #1456

Comments

@jrobinson01
Copy link

jrobinson01 commented Nov 15, 2018

In reading other issues, it doesn't look like checking .js files is supported out of the box, nor by adding the allowJs and checkJs compiler options to tsconfig.json. It DOES seem however, that adding a comment to the top of your .js files // @ts-check gets it working, except that it complains about that comment. this seems to be coming from the "ide-typescript" plugin and not "atom-typescript".

I see that support for allowJs and checkJs is up for grabs. I'd be interested in tackling it but am not familiar with this project at all. Would anyone be willing to point me at a starting point?

edit: Looks like this PR fixes my woes: #1456

@lierdakil lierdakil mentioned this issue Nov 17, 2018
10 tasks
@lierdakil
Copy link
Collaborator

Looks like this PR fixes my woes: #1456

Right. I missed #315 when referencing issues in that PR (the backlog is a horrifying place, so I tend to avoid staring there too much)

@lierdakil
Copy link
Collaborator

V12.7.0 is released which includes experimental support for JS. It's a bit hacky at the moment, but it should work for the most part. See: https://github.com/TypeStrong/atom-typescript/blob/master/docs/faq.md#i-want-to-use-atom-typescript-with-javascript-too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants