Skip to content

[Feature request] Add signature help #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
InExtremaRes opened this issue Apr 25, 2018 · 6 comments · Fixed by #1456
Closed

[Feature request] Add signature help #1421

InExtremaRes opened this issue Apr 25, 2018 · 6 comments · Fixed by #1456

Comments

@InExtremaRes
Copy link
Contributor

Is there a possibility of adding a signature help, so when you are calling a function (constructor, whatever) have a tooltip showing parameters name and type? It is very useful when calling a function with lots of arguments.

atom-ide-ui has this feature so, for instance, ide-typescript can use it directly. I don't know how much this package can (wants) use atom-ide-ui services or if is there any reason to do so.

image

@lierdakil
Copy link
Collaborator

lierdakil commented Apr 25, 2018

Should be possible I think?
There's a signatureHelp command in tsserver, and atom-ide-ui SignatureProvider interface seems reasonable

@InExtremaRes
Copy link
Contributor Author

Is any plans to integrate more (in whichever sense of the word) this package with atom-ide-ui?

@lierdakil
Copy link
Collaborator

There are no plans, but I don't see why not use a readily-available solution instead of inventing our own.

@InExtremaRes
Copy link
Contributor Author

Yes of course, just out of curiosity... and well, atom-ide-ui has a lots of services already there.

The only trade off I can think is the very different looks of those tooltips. Maybe more info could be ported as well (quickinfo, etc), but you know, it is just a bagatelle.

@lierdakil
Copy link
Collaborator

Maybe more info could be ported as well

I don't mind, although not everybody likes atom-ide-ui, so probably a good idea to leave an "escape hatch" in, so to speak.

@Xapphire13
Copy link

Seems this is either a dupe of, or related to #608

@lierdakil lierdakil mentioned this issue Oct 24, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants