Skip to content

Commit 33884be

Browse files
fix: Formatting toolbar mouseup handler (#1460)
1 parent 531429b commit 33884be

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

packages/core/src/extensions/FormattingToolbar/FormattingToolbarPlugin.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class FormattingToolbarView implements PluginView {
6767
};
6868

6969
pmView.dom.addEventListener("mousedown", this.viewMousedownHandler);
70-
pmView.dom.addEventListener("mouseup", this.viewMouseupHandler);
70+
pmView.root.addEventListener("mouseup", this.mouseupHandler);
7171
pmView.dom.addEventListener("dragstart", this.dragHandler);
7272
pmView.dom.addEventListener("dragover", this.dragHandler);
7373
pmView.dom.addEventListener("blur", this.blurHandler);
@@ -113,9 +113,11 @@ export class FormattingToolbarView implements PluginView {
113113
this.preventShow = true;
114114
};
115115

116-
viewMouseupHandler = () => {
117-
this.preventShow = false;
118-
setTimeout(() => this.update(this.pmView));
116+
mouseupHandler = () => {
117+
if (this.preventShow) {
118+
this.preventShow = false;
119+
setTimeout(() => this.update(this.pmView));
120+
}
119121
};
120122

121123
// For dragging the whole editor.
@@ -193,7 +195,7 @@ export class FormattingToolbarView implements PluginView {
193195

194196
destroy() {
195197
this.pmView.dom.removeEventListener("mousedown", this.viewMousedownHandler);
196-
this.pmView.dom.removeEventListener("mouseup", this.viewMouseupHandler);
198+
this.pmView.root.removeEventListener("mouseup", this.mouseupHandler);
197199
this.pmView.dom.removeEventListener("dragstart", this.dragHandler);
198200
this.pmView.dom.removeEventListener("dragover", this.dragHandler);
199201
this.pmView.dom.removeEventListener("blur", this.blurHandler);

0 commit comments

Comments
 (0)