-
Notifications
You must be signed in to change notification settings - Fork 37
Enable opting out of TSVI #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
penelopeysm
wants to merge
2
commits into
py/ldf
Choose a base branch
from
py/fastthreadsafe
base: py/ldf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+69
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Benchmark Report for Commit 6a0ecfaComputer InformationBenchmark Results |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## py/ldf #1128 +/- ##
==========================================
+ Coverage 81.67% 81.69% +0.01%
==========================================
Files 42 42
Lines 3919 3922 +3
==========================================
+ Hits 3201 3204 +3
Misses 718 718 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
penelopeysm
commented
Nov 8, 2025
Contributor
|
DynamicPPL.jl documentation for PR #1128 is available at: |
62c6351 to
9a74692
Compare
699aa23 to
c35dff5
Compare
9a74692 to
e5a038e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance gains in #1132 are only really significant when not using TSVI.
TSVI gets used more than it should (#1086).
This PR provides a mechanism to globally opt out of TSVI, in a way that is fully backwards-compatible.
Changing this to a global opt-in would just require changing the default to
false.A per-model opt-in would be doable too, albeit requiring more work. I think it's better to start from a global one and only consider a per-model one if people complain.
Performance
Edit: benchmarking this, I just realised that dereferencing
USE_THREADSAFE_EVALgives rise to more overhead than checking Threads.nthreads(). A per-model one should make this work better because if it's stored in the type, it can be removed at compile time. I'll investigate this further.