na in unbox

Author: TomAugspurger

pandas/core/arrays/datetimelike.py

@@ -89,17 +89,17 @@ def _get_attributes_dict(self):
 
     @property
     def _scalar_type(self):
+        # type: () -> Union[type, Tuple[type]]
         """The scalar associated with this datelike
 
         * PeriodArray : Period
         * DatetimeArray : Timestamp
         * TimedeltaArray : Timedelta
         """
-        # type: # () -> Union[type, Tuple[type]]
         raise AbstractMethodError(self)
 
     def _scalar_from_string(self, value):
-        # type: (str) -> Union[Period, Timestamp, Timedelta, NaT]
+        # type: (str) -> Union[Period, Timestamp, Timedelta, NaTType]
         """
         Construct a scalar type from a string.
 
@@ -120,6 +120,7 @@ def _scalar_from_string(self, value):
         raise AbstractMethodError(self)
 
     def _unbox_scalar(self, value):
+        # type: (Union[Period, Timestamp, Timedelta, NaTType]) -> int
         """
         Unbox the integer value of a scalar `value`.
 
@@ -139,6 +140,9 @@ def _unbox_scalar(self, value):
         raise AbstractMethodError(self)
 
     def _check_compatible_with(self, other):
+        # TODO: choose a type for other
+        # Can it be NaT?
+        # Scalar, array, or both?
         """
         Verify that `self` and `other` are compatible.
 

pandas/core/arrays/datetimes.py

@@ -439,7 +439,8 @@ def _generate_range(cls, start, end, periods, freq, tz=None,
     def _unbox_scalar(self, value):
         if not isinstance(value, (self._scalar_type, type(NaT))):
             raise ValueError("'value' should be a a Timestamp..")
-        self._check_compatible_with(value)
+        if not isna(value):
+            self._check_compatible_with(value)
         return value.value
 
     def _scalar_from_string(self, value):

pandas/core/arrays/period.py

@@ -240,7 +240,8 @@ def _unbox_scalar(self, value):
         if value is NaT:
             return value.value
         elif isinstance(value, self._scalar_type):
-            self._check_compatible_with(value)
+            if not isna(value):
+                self._check_compatible_with(value)
             return value.ordinal
         else:
             msg = (