Skip to content

12_findTheOldest fix ambiguity and remove redundant test description #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

12_findTheOldest fix ambiguity and remove redundant test description #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a6283
12_findTheOldest fix ambiguity and remove redundant test description
donRehan Jan 23, 2024
8bc6e47
Update findTheOldest test to clear ambiguity
donRehan Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 12_findTheOldest/findTheOldest.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('findTheOldest', () => {
]
expect(findTheOldest(people).name).toBe('Ray');
});
test.skip('finds the person with the greatest age if someone is still living', () => {
test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
const people = [
{
name: "Carly",
Expand All @@ -40,7 +40,7 @@ describe('findTheOldest', () => {
]
expect(findTheOldest(people).name).toBe('Ray');
});
test.skip('finds the person with the greatest age if the OLDEST is still living', () => {
test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
const people = [
{
name: "Carly",
Expand Down