Skip to content

Add a .github action to build DIRECTORY.md #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlesnoff merged 27 commits into from
Sep 8, 2023
Merged

Add a .github action to build DIRECTORY.md #36

dlesnoff merged 27 commits into from
Sep 8, 2023

Conversation

@dlesnoff
Copy link
Collaborator

@dlesnoff dlesnoff commented Jun 21, 2023 •
edited
Loading

I never wrote a github action myself before but I try to fix #25 .
There are probably a lot of mistakes.
To do:

  • Fix "every step must define a uses or run key".
  • Handle potential errors from the script DIRECTORY.nim
  • Generates a pull request

@dlesnoff dlesnoff requested a review from Panquesito7 as a code owner June 21, 2023 13:28
@dlesnoff dlesnoff marked this pull request as draft June 21, 2023 13:37
@dlesnoff dlesnoff force-pushed the directory-action branch 3 times, most recently from 11056ed to fb55f7f Compare June 23, 2023 12:42
@dlesnoff dlesnoff marked this pull request as ready for review June 23, 2023 13:48
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 23, 2023
Panquesito7
Panquesito7 requested changes Jun 23, 2023
View reviewed changes
Panquesito7
Panquesito7 requested changes Jul 3, 2023
View reviewed changes
Panquesito7 and others added 16 commits July 4, 2023 11:03
@Panquesito7 @dlesnoff
chore: minor Gitpod improvements (TheAlgorithms#34)
7066ed7 
Add Gitpod badge and prebuilds for all branches and forks
@janAkali @dlesnoff
Add binary search (TheAlgorithms#37)
f7303c7 
* Add binary search

* Update binary search: add recursive version

* Update binary search: better description

* Update binary search: update runnableExamples

* Update binary search: improve tests, add overload for recursive func

* Update binary search: evaluate if-expression into result

* grammar

* Update binary search: improve description, add comments

* Update binary search: add missing test cases

* Update binary search: add info about pivot choice in description, rearrange it

* Update binary search: change int to Natural

* Update binary search: if block -> guard clause

* Update binary search: test cases

* Update binary search: simplify docs

* Update binary search: nimpretty
@dlesnoff @Panquesito7
Apply suggestions from code review
4c5dc75 
Co-authored-by: David Leal <[email protected]>
@dlesnoff
Replace by an attempt of github pr create
f94a151
@dlesnoff @Panquesito7
Fix branching and environment variable in the PR
0456550 
Co-authored-by: David Leal <[email protected]>
@dlesnoff @ZoomRmc
@pietroppeter @Panquesito7
Create and populate the Maths directory (TheAlgorithms#4)
8899dd8 
* Add a sample of maths basic algorithms

* Update maths/abs.nim

Co-authored-by: Zoom <[email protected]>

* Use openArray in absMaxSort

Co-authored-by: Zoom <[email protected]>

* Fix seq->openArray and int->SomeInteger

* Use Positive as input instead

* Update maths/addition_without_arithmetic.nim

Co-authored-by: Pietro Peterlongo <[email protected]>

* Name allocation number

* [maths/abs] Replace maxAbsSort by signed[Min/Max]Abs

* [Aliquot Sum] Add header

* Add empty line at end of file

* Remove Allocation number since it is a non standard algorithm

* Fix titles

* Run nimpretty on the files

* Rename file and add DIRECTORY.md

* abs: Fix variable name

* Add export marker

Co-authored-by: Zoom <[email protected]>

* Add RE block in aliquot sum and improve RE

Co-authored-by: Zoom <[email protected]>

* Remove MD quotation marks for inline code

* Add export marker for RE block

* Remove extra ValueError

---------

Co-authored-by: Dimitri LESNOFF <[email protected]>
Co-authored-by: Zoom <[email protected]>
Co-authored-by: Pietro Peterlongo <[email protected]>
Co-authored-by: David Leal <[email protected]>
@dlesnoff
Add arc length (TheAlgorithms#10)
cf26bd2
@dlesnoff @SatinWukerORIG @ZoomRmc
Fix linear search (TheAlgorithms#33)
46f212b 
* Use a dynamic allocated array (sequence) for strings

* Run nimpretty

* Add requested changes

* Fix documentation generation

* Fix test title according to changes

Co-authored-by: Satin Wuker <[email protected]>

* Update comments to warn about indexing issues

Modified a bit the suggestions of comments. Please check them before approving.

Co-authored-by: Zoom <[email protected]>

---------

Co-authored-by: Dimitri LESNOFF <[email protected]>
Co-authored-by: Satin Wuker <[email protected]>
Co-authored-by: Zoom <[email protected]>
@Panquesito7 @dlesnoff
chore: run apt-get update before running other commands (TheAlgorit…
8726e3b 
…hms#41)

This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).
@ZoomRmc @dlesnoff
Readme: fix gitter link, add Nim logo, formatting fixes (TheAlgorithm…
828a32e 
…s#42)

* Update README.md

Use more extended markdown syntax instead of HTML,
Add Matrix links
Superseed PR TheAlgorithms#40

* Actually fix gitter! Move img src links to footer.

Also changed the TheAlgorithms logo image link.

* Restore TheAlgorithms logo link

* More link fixes

---------

Co-authored-by: dlesnoff <[email protected]>
@ZoomRmc @dlesnoff
fix: nimpretty for arc_length.nim (TheAlgorithms#43)
af73df1
@ZoomRmc @dlesnoff
chore: gc->mm, move back to config.nims (TheAlgorithms#47)
f7857f8
@vil02 @dlesnoff
chore: revert TheAlgorithms#41 (TheAlgorithms#45)
7dc52f7
@Panquesito7 @dlesnoff
Update codeowners
f16fbb2
@ayushsgithub @dlesnoff
Fix: CONTRIBUTING.md links (TheAlgorithms#49)
2ffdee1 
Uppercase `directory.md` to `DIRECTORY.md`
@vil02 @ZoomRmc @dlesnoff
feat: add Levenshtein distance (TheAlgorithms#46)
19f2fb6 
* feat: add Levenshtein distance

* Apply suggestions from code review

Co-authored-by: Zoom <[email protected]>

* refactor: use toKey in initSubsolutions

* style: use .Natural

* style: remove blank line

* refactor: add Key type

* style: use descriptive variable names

* style: use a, b instead of strA, strB

* docs: add note about complexity

* refator: add name to TestCase

* docs: remove sentence about dp

* docs: update documentation of `levenshteinDistance`

Co-authored-by: Zoom <[email protected]>

* docs: rename initLevenshteinDistanceMatrix and add its documentation

* refactor: add fillLevenshteinDistanceMatrix

* tests: reorganise tests, remove TestCase type

* docs: add edit distance to module-level documentation

* docs: mention Wagner–Fischer algorithm

* docs: add comment in fillLevenshteinDistanceMatrix

* style: reformat fillLevenshteinDistanceMatrix

* docs: update DIRECTORY.md

---------

Co-authored-by: Zoom <[email protected]>
vil02 and others added 2 commits July 4, 2023 11:03
@vil02 @ZoomRmc @dlesnoff
docs: add missing # (TheAlgorithms#50)
1a5b80e 
* docs: add missing `#`

* docs: update DIRECTORY.md

* docs: remove ` of a Circle`

Co-authored-by: Zoom <[email protected]>

* docs: update DIRECTORY.md

---------

Co-authored-by: Zoom <[email protected]>
@ZoomRmc @dlesnoff
Implement Gale-Shapley stable matching (TheAlgorithms#35)
c00766d 
* Implement Gale-Shapley stable matching

This is an adaptation of my much earlier implementation made
for the RosettaCode project. The additional requirements of the
task were moved to the runnableExamples block.

The code was updated, thoroughly checked and commented.

The name for the category is similar to one used for earlier
C# and Lua implementations.

* Add more docs; `Clash` made numerical

* Remove repetition in module's RE block

---------

Co-authored-by: dlesnoff <[email protected]>
@dlesnoff dlesnoff force-pushed the directory-action branch from 8a7fdf3 to c00766d Compare July 4, 2023 09:05
@dlesnoff
Copy link
Collaborator Author

dlesnoff commented Jul 4, 2023 •
edited
Loading

I am sorry, I merged another branch with an algorithm not yet in the repository to see if the action really works and this messed up the history.

6 participants

Please remove the extra participants from the git message if you merge this PR.

Panquesito7
Panquesito7 reviewed Jul 17, 2023
View reviewed changes
@Panquesito7
Copy link
Member

Panquesito7 commented Sep 1, 2023

Hey there! Just checking in: do you need any help or would you like me to work on this? Thanks. 🙂

@dlesnoff
Copy link
Collaborator Author

dlesnoff commented Sep 7, 2023 •
edited
Loading

I am not sure what this PR requires additionally.
— no need to update it on a time basis. This might be the object of another PR too.
— we might want to check the status code of the directory.nim script. What happens if it fails?

I prefer to focus on the algorithms themselves.
Thanks for the help.

@dlesnoff
Copy link
Collaborator Author

dlesnoff commented Sep 7, 2023 •
edited
Loading

I made a change to report the eventual error statuses of the compilation or of the execution of the script.
checkout is now updated to the fourth version as done in #58.

Panquesito7
Panquesito7 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 🚀 Let's test it out.

@dlesnoff dlesnoff merged commit 9c7501c into TheAlgorithms:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Update DIRECTORY.md file (semi-)automatically

6 participants

@dlesnoff @Panquesito7 @janAkali @ZoomRmc @vil02 @ayushsgithub