-
Notifications
You must be signed in to change notification settings - Fork 19
Why no fasta-redux? #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the fasta-redux of the rust distribution does not pass the tests. And I don't understand the difference between fasta and fasta-redux, thus I did not take the time to investiguate on this benchmark. I'll be happy to accept a PR with a fasta-redux implementation :) |
The difference is that the redux version should build a lookup table from which the amino acid should be queried. I have taken the "original" Rust version and changed it so that the output matches the requirements (and also the algorithm should, to the best of my knowledge). I'll try and make a PR to rust-lang/rust first. Should they add it, feel free to grab it from there, otherwise I'll gladly make a PR here. |
You can open a PR here. Don't forget to change the header. The last contributor is the one that will submit the benchmark. So put me at the end and I'll submit the bench, or put yourself last but then you'll need to submit it yourself. |
PR #6 opened. I'm closing this issue. |
I noticed that there is no fasta-redux implementation, though the Rust distribution has one. Is there a reason for that?
The text was updated successfully, but these errors were encountered: