Skip to content

Why no fasta-redux? #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
llogiq opened this issue Aug 10, 2015 · 5 comments
Closed

Why no fasta-redux? #5

llogiq opened this issue Aug 10, 2015 · 5 comments

Comments

@llogiq
Copy link
Contributor

llogiq commented Aug 10, 2015

I noticed that there is no fasta-redux implementation, though the Rust distribution has one. Is there a reason for that?

@TeXitoi
Copy link
Owner

TeXitoi commented Aug 10, 2015

I think the fasta-redux of the rust distribution does not pass the tests. And I don't understand the difference between fasta and fasta-redux, thus I did not take the time to investiguate on this benchmark.

I'll be happy to accept a PR with a fasta-redux implementation :)

@llogiq
Copy link
Contributor Author

llogiq commented Aug 10, 2015

The difference is that the redux version should build a lookup table from which the amino acid should be queried. I have taken the "original" Rust version and changed it so that the output matches the requirements (and also the algorithm should, to the best of my knowledge).

I'll try and make a PR to rust-lang/rust first. Should they add it, feel free to grab it from there, otherwise I'll gladly make a PR here.

@llogiq
Copy link
Contributor Author

llogiq commented Aug 11, 2015

The PR has been accepted and now waits for the next rollup. @TeXitoi Do you want to pull from there or should I add a PR here, too?

@TeXitoi
Copy link
Owner

TeXitoi commented Aug 11, 2015

You can open a PR here. Don't forget to change the header. The last contributor is the one that will submit the benchmark. So put me at the end and I'll submit the bench, or put yourself last but then you'll need to submit it yourself.

@llogiq
Copy link
Contributor Author

llogiq commented Aug 11, 2015

PR #6 opened. I'm closing this issue.

@llogiq llogiq closed this as completed Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants