-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: remove gitignore suggestion for generated route tree file #6025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoved a note from the React and Solid framework routing documentation stating that the routeTree.gen.ts file may be gitignored as a build artifact. These are documentation-only edits with no functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR resolves a documentation inconsistency between TanStack Router and TanStack Start regarding the routeTree.gen.ts file. The Router documentation explicitly states this file should be committed to git as it's part of the application's runtime, not a build artifact, while the Start documentation incorrectly suggested gitignoring it as a build artifact.
- Removed the conflicting gitignore recommendation from Start documentation
- Established Router FAQ as the single source of truth for handling the generated route tree file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/start/framework/react/guide/routing.md | Removed the statement suggesting to gitignore routeTree.gen.ts as a build artifact |
| docs/start/framework/solid/guide/routing.md | Removed the statement suggesting to gitignore routeTree.gen.ts as a build artifact |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tack#6025) docs: remove gitignore suggestion for generated routing files in start docs
As per issue #5354
This PR resolves an inconsistency between Router and Start documentation about whether to commit the generated route tree file
routeTree.gen.tsand if it is a build artifact.Router docs says:
Start docs says
Changes:
Removed the recommendation to .gitignore the
routeTree.gen.tsfile from the Start documentation.Establishes the Router documentation as the single source of truth for handling generated route files.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.