From 86714c25e73ec7f3c82952a3a3c09fffd246e6ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=9D=EC=A7=84?= Date: Wed, 7 May 2025 22:06:42 +0900 Subject: [PATCH 1/4] test(react-query): improve branch coverage for useSuspenseQuery skipToken error handling --- .../src/__tests__/useSuspenseQuery.test.tsx | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx index 06b8e61d07..c74f3cd39a 100644 --- a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx @@ -965,4 +965,67 @@ describe('useSuspenseQuery', () => { expect(count).toBeGreaterThanOrEqual(3) }) + + it('should not log an error when proper queryFn is provided', () => { + const envCopy = process.env.NODE_ENV + process.env.NODE_ENV = 'development' + + const consoleErrorSpy = vi + .spyOn(console, 'error') + .mockImplementation(() => undefined) + const key = queryKey() + + function Page() { + useSuspenseQuery({ + queryKey: key, + queryFn: () => Promise.resolve('data'), + }) + + return null + } + + renderWithClient( + queryClient, + + + + ) + + expect(consoleErrorSpy).not.toHaveBeenCalledWith( + 'skipToken is not allowed for useSuspenseQuery' + ) + consoleErrorSpy.mockRestore() + process.env.NODE_ENV = envCopy + }) + + it('should handle non-production environment checks properly', () => { + const envCopy = process.env.NODE_ENV + process.env.NODE_ENV = 'production' + + const consoleErrorSpy = vi + .spyOn(console, 'error') + .mockImplementation(() => undefined) + const key = queryKey() + + function Page() { + useSuspenseQuery({ + queryKey: key, + queryFn: skipToken as any, + }) + + return null + } + + renderWithClient( + queryClient, + + + + ) + + expect(consoleErrorSpy).not.toHaveBeenCalled() + + consoleErrorSpy.mockRestore() + process.env.NODE_ENV = envCopy + }) }) From 6acb4822b3e43eb1835323b033ed40309fe04d95 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Wed, 7 May 2025 13:09:44 +0000 Subject: [PATCH 2/4] ci: apply automated fixes --- .../react-query/src/__tests__/useSuspenseQuery.test.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx index c74f3cd39a..de2f4cb7ec 100644 --- a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx @@ -988,11 +988,11 @@ describe('useSuspenseQuery', () => { queryClient, - + , ) expect(consoleErrorSpy).not.toHaveBeenCalledWith( - 'skipToken is not allowed for useSuspenseQuery' + 'skipToken is not allowed for useSuspenseQuery', ) consoleErrorSpy.mockRestore() process.env.NODE_ENV = envCopy @@ -1020,7 +1020,7 @@ describe('useSuspenseQuery', () => { queryClient, - + , ) expect(consoleErrorSpy).not.toHaveBeenCalled() From b753fc0e185161a6de6407057f610d5c93870769 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B9=80=EC=84=9D=EC=A7=84?= Date: Wed, 7 May 2025 22:20:10 +0900 Subject: [PATCH 3/4] fix(react-query): update --- .../src/__tests__/useSuspenseQuery.test.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx index de2f4cb7ec..ac0506dfa5 100644 --- a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx @@ -966,7 +966,7 @@ describe('useSuspenseQuery', () => { expect(count).toBeGreaterThanOrEqual(3) }) - it('should not log an error when proper queryFn is provided', () => { + it('should log an error when skipToken is used in development environment', () => { const envCopy = process.env.NODE_ENV process.env.NODE_ENV = 'development' @@ -978,7 +978,7 @@ describe('useSuspenseQuery', () => { function Page() { useSuspenseQuery({ queryKey: key, - queryFn: () => Promise.resolve('data'), + queryFn: skipToken as any, }) return null @@ -991,14 +991,15 @@ describe('useSuspenseQuery', () => { , ) - expect(consoleErrorSpy).not.toHaveBeenCalledWith( - 'skipToken is not allowed for useSuspenseQuery', + expect(consoleErrorSpy).toHaveBeenCalledWith( + 'skipToken is not allowed for useSuspenseQuery' ) + consoleErrorSpy.mockRestore() process.env.NODE_ENV = envCopy }) - it('should handle non-production environment checks properly', () => { + it('should not log an error when skipToken is used in production environment', () => { const envCopy = process.env.NODE_ENV process.env.NODE_ENV = 'production' From 1712b307fc830e84214f16e16c65b2790872a174 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Wed, 7 May 2025 13:20:47 +0000 Subject: [PATCH 4/4] ci: apply automated fixes --- packages/react-query/src/__tests__/useSuspenseQuery.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx index ac0506dfa5..cbc0a3a50c 100644 --- a/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx +++ b/packages/react-query/src/__tests__/useSuspenseQuery.test.tsx @@ -992,7 +992,7 @@ describe('useSuspenseQuery', () => { ) expect(consoleErrorSpy).toHaveBeenCalledWith( - 'skipToken is not allowed for useSuspenseQuery' + 'skipToken is not allowed for useSuspenseQuery', ) consoleErrorSpy.mockRestore()