From ba83d27b8fd1f4baddeb736878a482dd3e2c8db8 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 13:25:34 +0200 Subject: [PATCH 01/12] fix(react-query-devtools): only export devtools in development mode --- packages/react-query-devtools/src/index.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index 39356ff2a4..f7ca14e8cb 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1 +1,12 @@ -export * from './devtools' +if (process.env.NODE_ENV !== 'development') { + module.exports = { + ReactQueryDevtools: function () { + return null + }, + ReactQueryDevtoolsPanel: function () { + return null + }, + } +} else { + module.exports = require('./devtools') +} From 9736304a293e587f7c5daa040e5a2f63e1fa6046 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 13:35:31 +0200 Subject: [PATCH 02/12] fix(react-query-devtools): only export devtools in development mode fix types import --- packages/react-query-devtools/src/__tests__/utils.tsx | 2 +- packages/react-query-devtools/src/devtools.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-query-devtools/src/__tests__/utils.tsx b/packages/react-query-devtools/src/__tests__/utils.tsx index 030b9c0344..4e6827e4ba 100644 --- a/packages/react-query-devtools/src/__tests__/utils.tsx +++ b/packages/react-query-devtools/src/__tests__/utils.tsx @@ -1,7 +1,7 @@ import { MatcherFunction } from '@testing-library/dom/types/matches' import { render } from '@testing-library/react' import * as React from 'react' -import { ReactQueryDevtools } from '..' +import { ReactQueryDevtools } from '../devtools' import { QueryClient, diff --git a/packages/react-query-devtools/src/devtools.tsx b/packages/react-query-devtools/src/devtools.tsx index 623b5c2d89..10d3b76ebd 100644 --- a/packages/react-query-devtools/src/devtools.tsx +++ b/packages/react-query-devtools/src/devtools.tsx @@ -29,7 +29,7 @@ import { getQueryStatusLabel, getQueryStatusColor } from './utils' import Explorer from './Explorer' import Logo from './Logo' -interface DevtoolsOptions extends ContextOptions { +export interface DevtoolsOptions extends ContextOptions { /** * Set this true if you want the dev tools to default to being open */ From 4937ac3eb43b60cb743b5733472e269bb77ce1ad Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 19:39:23 +0200 Subject: [PATCH 03/12] fix(react-query-devtools): only export devtools in development mode try to ship empty devtools --- package.json | 1 + packages/react-query-devtools/package.json | 6 ++++++ packages/react-query-devtools/src/devtools-empty.ts | 9 +++++++++ 3 files changed, 16 insertions(+) create mode 100644 packages/react-query-devtools/src/devtools-empty.ts diff --git a/package.json b/package.json index 0bc8968378..3370eea4f6 100644 --- a/package.json +++ b/package.json @@ -15,6 +15,7 @@ "test:jest:dev": "jest --config ./jest.config.ts --watch", "test:size": "npm run build && bundlewatch", "build": "rollup --config rollup.config.js && npm run typecheck", + "postbuild": "cp ./packages/react-query-devtools/src/devtools-empty.ts ./packages/react-query-devtools/build/esm/devtools-empty.js", "typecheck": "tsc -b", "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"npm run typecheck -- --watch\" \"npm run test\"", "linkAll": "lerna exec 'npm run link' --parallel", diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json index 0b212ae121..d487ca8482 100644 --- a/packages/react-query-devtools/package.json +++ b/packages/react-query-devtools/package.json @@ -18,6 +18,12 @@ "build/*", "src" ], + "exports": { + "development": { + "default": "./build/esm/index.js" + }, + "default": "./build/esm/devtools-empty.js" + }, "scripts": { "test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src", "compile": "../../node_modules/.bin/tsc -p tsconfig.json --noEmit --emitDeclarationOnly false" diff --git a/packages/react-query-devtools/src/devtools-empty.ts b/packages/react-query-devtools/src/devtools-empty.ts new file mode 100644 index 0000000000..ea5a4c3a43 --- /dev/null +++ b/packages/react-query-devtools/src/devtools-empty.ts @@ -0,0 +1,9 @@ +function ReactQueryDevtools() { + return null +} + +function ReactQueryDevtoolsPanel() { + return null +} + +export { ReactQueryDevtools, ReactQueryDevtoolsPanel } From d673a82da2eea0575bb59eacd686f705a556a2b6 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 19:40:43 +0200 Subject: [PATCH 04/12] fix(react-query-devtools): only export devtools in development mode revert the node_env check --- packages/react-query-devtools/src/index.ts | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index f7ca14e8cb..39356ff2a4 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1,12 +1 @@ -if (process.env.NODE_ENV !== 'development') { - module.exports = { - ReactQueryDevtools: function () { - return null - }, - ReactQueryDevtoolsPanel: function () { - return null - }, - } -} else { - module.exports = require('./devtools') -} +export * from './devtools' From 21e12c3ba2b43cadda5c49e555c17de1b80fefd1 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 19:42:45 +0200 Subject: [PATCH 05/12] fix(react-query-devtools): only export devtools in development mode revert revert the node_env check --- packages/react-query-devtools/src/index.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index 39356ff2a4..f7ca14e8cb 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1 +1,12 @@ -export * from './devtools' +if (process.env.NODE_ENV !== 'development') { + module.exports = { + ReactQueryDevtools: function () { + return null + }, + ReactQueryDevtoolsPanel: function () { + return null + }, + } +} else { + module.exports = require('./devtools') +} From 006863a1bb5a989b2219caf81698fa5b3aed78e4 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Tue, 19 Jul 2022 20:08:02 +0200 Subject: [PATCH 06/12] fix(react-query-devtools): only export devtools in development mode --- package.json | 2 +- packages/react-query-devtools/package.json | 4 ++-- packages/react-query-devtools/src/devtools-dev.ts | 1 + .../src/{devtools-empty.ts => devtools-prod.ts} | 0 4 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 packages/react-query-devtools/src/devtools-dev.ts rename packages/react-query-devtools/src/{devtools-empty.ts => devtools-prod.ts} (100%) diff --git a/package.json b/package.json index 3370eea4f6..d2cfd4524b 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "test:jest:dev": "jest --config ./jest.config.ts --watch", "test:size": "npm run build && bundlewatch", "build": "rollup --config rollup.config.js && npm run typecheck", - "postbuild": "cp ./packages/react-query-devtools/src/devtools-empty.ts ./packages/react-query-devtools/build/esm/devtools-empty.js", + "postbuild": "cp ./packages/react-query-devtools/src/devtools-dev.ts ./packages/react-query-devtools/build/esm/devtools-dev.js && cp ./packages/react-query-devtools/src/devtools-prod.ts ./packages/react-query-devtools/build/esm/devtools-prod.js", "typecheck": "tsc -b", "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"npm run typecheck -- --watch\" \"npm run test\"", "linkAll": "lerna exec 'npm run link' --parallel", diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json index d487ca8482..49c78e4755 100644 --- a/packages/react-query-devtools/package.json +++ b/packages/react-query-devtools/package.json @@ -20,9 +20,9 @@ ], "exports": { "development": { - "default": "./build/esm/index.js" + "default": "./build/esm/devtool-dev.js" }, - "default": "./build/esm/devtools-empty.js" + "default": "./build/esm/devtools-prod.js" }, "scripts": { "test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src", diff --git a/packages/react-query-devtools/src/devtools-dev.ts b/packages/react-query-devtools/src/devtools-dev.ts new file mode 100644 index 0000000000..39356ff2a4 --- /dev/null +++ b/packages/react-query-devtools/src/devtools-dev.ts @@ -0,0 +1 @@ +export * from './devtools' diff --git a/packages/react-query-devtools/src/devtools-empty.ts b/packages/react-query-devtools/src/devtools-prod.ts similarity index 100% rename from packages/react-query-devtools/src/devtools-empty.ts rename to packages/react-query-devtools/src/devtools-prod.ts From 7a7af15c3f3ac22d8fad4a0fca8078c18e495056 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 09:53:07 +0200 Subject: [PATCH 07/12] fix(react-query-devtools): only export devtools in development mode another attempt --- package.json | 1 - packages/react-query-devtools/package.json | 6 ----- .../src/__tests__/devtools.test.tsx | 2 +- .../react-query-devtools/src/devtools.tsx | 24 +------------------ packages/react-query-devtools/src/index.ts | 24 +++++++++++-------- packages/react-query-devtools/src/utils.ts | 21 ++++++++++++++++ 6 files changed, 37 insertions(+), 41 deletions(-) diff --git a/package.json b/package.json index d2cfd4524b..0bc8968378 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,6 @@ "test:jest:dev": "jest --config ./jest.config.ts --watch", "test:size": "npm run build && bundlewatch", "build": "rollup --config rollup.config.js && npm run typecheck", - "postbuild": "cp ./packages/react-query-devtools/src/devtools-dev.ts ./packages/react-query-devtools/build/esm/devtools-dev.js && cp ./packages/react-query-devtools/src/devtools-prod.ts ./packages/react-query-devtools/build/esm/devtools-prod.js", "typecheck": "tsc -b", "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"npm run typecheck -- --watch\" \"npm run test\"", "linkAll": "lerna exec 'npm run link' --parallel", diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json index 49c78e4755..0b212ae121 100644 --- a/packages/react-query-devtools/package.json +++ b/packages/react-query-devtools/package.json @@ -18,12 +18,6 @@ "build/*", "src" ], - "exports": { - "development": { - "default": "./build/esm/devtool-dev.js" - }, - "default": "./build/esm/devtools-prod.js" - }, "scripts": { "test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src", "compile": "../../node_modules/.bin/tsc -p tsconfig.json --noEmit --emitDeclarationOnly false" diff --git a/packages/react-query-devtools/src/__tests__/devtools.test.tsx b/packages/react-query-devtools/src/__tests__/devtools.test.tsx index d02b4a14c3..3e0758b2bc 100644 --- a/packages/react-query-devtools/src/__tests__/devtools.test.tsx +++ b/packages/react-query-devtools/src/__tests__/devtools.test.tsx @@ -3,7 +3,7 @@ import { fireEvent, screen, waitFor, act } from '@testing-library/react' import { ErrorBoundary } from 'react-error-boundary' import '@testing-library/jest-dom' import { useQuery, QueryClient } from '@tanstack/react-query' -import { sortFns } from '../devtools' +import { sortFns } from '../utils' import { getByTextContent, renderWithClient, diff --git a/packages/react-query-devtools/src/devtools.tsx b/packages/react-query-devtools/src/devtools.tsx index 10d3b76ebd..7070228364 100644 --- a/packages/react-query-devtools/src/devtools.tsx +++ b/packages/react-query-devtools/src/devtools.tsx @@ -1,7 +1,6 @@ import * as React from 'react' import { useSyncExternalStore } from 'use-sync-external-store/shim' import { - Query, useQueryClient, onlineManager, notifyManager, @@ -12,7 +11,7 @@ import { } from '@tanstack/react-query' import { rankItem, compareItems } from '@tanstack/match-sorter-utils' import useLocalStorage from './useLocalStorage' -import { useIsMounted } from './utils' +import { sortFns, useIsMounted } from './utils' import { Panel, @@ -375,27 +374,6 @@ export function ReactQueryDevtools({ ) } -const getStatusRank = (q: Query) => - q.state.fetchStatus !== 'idle' - ? 0 - : !q.getObserversCount() - ? 3 - : q.isStale() - ? 2 - : 1 - -export const sortFns: Record number> = { - 'Status > Last Updated': (a, b) => - getStatusRank(a) === getStatusRank(b) - ? (sortFns['Last Updated']?.(a, b) as number) - : getStatusRank(a) > getStatusRank(b) - ? 1 - : -1, - 'Query Hash': (a, b) => (a.queryHash > b.queryHash ? 1 : -1), - 'Last Updated': (a, b) => - a.state.dataUpdatedAt < b.state.dataUpdatedAt ? 1 : -1, -} - const useSubscribeToQueryCache = ( queryCache: QueryCache, getSnapshot: () => T, diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index f7ca14e8cb..cad8852388 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1,12 +1,16 @@ -if (process.env.NODE_ENV !== 'development') { - module.exports = { - ReactQueryDevtools: function () { - return null - }, - ReactQueryDevtoolsPanel: function () { - return null - }, +import * as devtools from './devtools' + +export let ReactQueryDevtools: typeof devtools['ReactQueryDevtools'] = + function () { + return null } -} else { - module.exports = require('./devtools') + +export let ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = + function () { + return null + } as any + +if (process.env.NODE_ENV === 'development') { + ReactQueryDevtools = devtools.ReactQueryDevtools + ReactQueryDevtoolsPanel = devtools.ReactQueryDevtoolsPanel } diff --git a/packages/react-query-devtools/src/utils.ts b/packages/react-query-devtools/src/utils.ts index a01cd15150..19aa12978b 100644 --- a/packages/react-query-devtools/src/utils.ts +++ b/packages/react-query-devtools/src/utils.ts @@ -124,3 +124,24 @@ export const displayValue = (value: unknown) => { return JSON.stringify(newValue, name) } + +const getStatusRank = (q: Query) => + q.state.fetchStatus !== 'idle' + ? 0 + : !q.getObserversCount() + ? 3 + : q.isStale() + ? 2 + : 1 + +export const sortFns: Record number> = { + 'Status > Last Updated': (a, b) => + getStatusRank(a) === getStatusRank(b) + ? (sortFns['Last Updated']?.(a, b) as number) + : getStatusRank(a) > getStatusRank(b) + ? 1 + : -1, + 'Query Hash': (a, b) => (a.queryHash > b.queryHash ? 1 : -1), + 'Last Updated': (a, b) => + a.state.dataUpdatedAt < b.state.dataUpdatedAt ? 1 : -1, +} From 0fe614a35977b93979c805e6f825ad914227c03a Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 10:18:26 +0200 Subject: [PATCH 08/12] fix(react-query-devtools): only export devtools in development mode remove outdated files --- packages/react-query-devtools/src/devtools-dev.ts | 1 - packages/react-query-devtools/src/devtools-prod.ts | 9 --------- packages/react-query-devtools/src/index.ts | 2 +- 3 files changed, 1 insertion(+), 11 deletions(-) delete mode 100644 packages/react-query-devtools/src/devtools-dev.ts delete mode 100644 packages/react-query-devtools/src/devtools-prod.ts diff --git a/packages/react-query-devtools/src/devtools-dev.ts b/packages/react-query-devtools/src/devtools-dev.ts deleted file mode 100644 index 39356ff2a4..0000000000 --- a/packages/react-query-devtools/src/devtools-dev.ts +++ /dev/null @@ -1 +0,0 @@ -export * from './devtools' diff --git a/packages/react-query-devtools/src/devtools-prod.ts b/packages/react-query-devtools/src/devtools-prod.ts deleted file mode 100644 index ea5a4c3a43..0000000000 --- a/packages/react-query-devtools/src/devtools-prod.ts +++ /dev/null @@ -1,9 +0,0 @@ -function ReactQueryDevtools() { - return null -} - -function ReactQueryDevtoolsPanel() { - return null -} - -export { ReactQueryDevtools, ReactQueryDevtoolsPanel } diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index cad8852388..10045a9ea0 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -10,7 +10,7 @@ export let ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = return null } as any -if (process.env.NODE_ENV === 'development') { +if (process.env.NODE_ENV !== 'production') { ReactQueryDevtools = devtools.ReactQueryDevtools ReactQueryDevtoolsPanel = devtools.ReactQueryDevtoolsPanel } From bc812ca92331a2915319ed7ec4096d04393285cb Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 11:49:33 +0200 Subject: [PATCH 09/12] fix(react-query-devtools): only export devtools in development mode remove main field from package.json --- packages/react-query-devtools/package.json | 1 - packages/react-query-devtools/src/index.ts | 25 +++++++++++----------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json index 0b212ae121..b90eef5b8e 100644 --- a/packages/react-query-devtools/package.json +++ b/packages/react-query-devtools/package.json @@ -10,7 +10,6 @@ "type": "github", "url": "https://github.com/sponsors/tannerlinsley" }, - "module": "build/esm/index.js", "main": "build/cjs/packages/react-query-devtools/src/index.js", "browser": "build/umd/index.production.js", "types": "build/types/react-query-devtools/src/index.d.ts", diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index 10045a9ea0..8aa33380d4 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1,16 +1,15 @@ import * as devtools from './devtools' -export let ReactQueryDevtools: typeof devtools['ReactQueryDevtools'] = - function () { - return null - } +export const ReactQueryDevtools: typeof devtools['ReactQueryDevtools'] = + process.env.NODE_ENV !== 'production' + ? devtools.ReactQueryDevtools + : function () { + return null + } -export let ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = - function () { - return null - } as any - -if (process.env.NODE_ENV !== 'production') { - ReactQueryDevtools = devtools.ReactQueryDevtools - ReactQueryDevtoolsPanel = devtools.ReactQueryDevtoolsPanel -} +export const ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = + process.env.NODE_ENV !== 'production' + ? devtools.ReactQueryDevtoolsPanel + : (function () { + return null + } as any) From df9c197e36b6d59eb13d4f9f980a3a25e309930b Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 11:56:32 +0200 Subject: [PATCH 10/12] fix(react-query-devtools): only export devtools in development mode back to require --- packages/react-query-devtools/src/index.ts | 27 ++++++++++------------ 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index 8aa33380d4..f7ca14e8cb 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1,15 +1,12 @@ -import * as devtools from './devtools' - -export const ReactQueryDevtools: typeof devtools['ReactQueryDevtools'] = - process.env.NODE_ENV !== 'production' - ? devtools.ReactQueryDevtools - : function () { - return null - } - -export const ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = - process.env.NODE_ENV !== 'production' - ? devtools.ReactQueryDevtoolsPanel - : (function () { - return null - } as any) +if (process.env.NODE_ENV !== 'development') { + module.exports = { + ReactQueryDevtools: function () { + return null + }, + ReactQueryDevtoolsPanel: function () { + return null + }, + } +} else { + module.exports = require('./devtools') +} From c412df02792aad14f042ef06531bd318b4efbb79 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 16:00:39 +0200 Subject: [PATCH 11/12] fix(react-query-devtools): only export devtools in development mode finally --- package.json | 1 + packages/react-query-devtools/package.json | 7 +++++++ packages/react-query-devtools/src/index.ts | 13 +------------ 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 0bc8968378..f109b75aef 100644 --- a/package.json +++ b/package.json @@ -15,6 +15,7 @@ "test:jest:dev": "jest --config ./jest.config.ts --watch", "test:size": "npm run build && bundlewatch", "build": "rollup --config rollup.config.js && npm run typecheck", + "postbuild": "cp ./packages/react-query-devtools/src/noop.ts ./packages/react-query-devtools/build/esm/noop.js", "typecheck": "tsc -b", "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"npm run typecheck -- --watch\" \"npm run test\"", "linkAll": "lerna exec 'npm run link' --parallel", diff --git a/packages/react-query-devtools/package.json b/packages/react-query-devtools/package.json index b90eef5b8e..edf06fe246 100644 --- a/packages/react-query-devtools/package.json +++ b/packages/react-query-devtools/package.json @@ -10,6 +10,7 @@ "type": "github", "url": "https://github.com/sponsors/tannerlinsley" }, + "module": "build/esm/index.js", "main": "build/cjs/packages/react-query-devtools/src/index.js", "browser": "build/umd/index.production.js", "types": "build/types/react-query-devtools/src/index.d.ts", @@ -17,6 +18,12 @@ "build/*", "src" ], + "exports": { + "development": { + "default": "./build/esm/index.js" + }, + "default": "./build/esm/noop.js" + }, "scripts": { "test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src", "compile": "../../node_modules/.bin/tsc -p tsconfig.json --noEmit --emitDeclarationOnly false" diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index f7ca14e8cb..39356ff2a4 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1,12 +1 @@ -if (process.env.NODE_ENV !== 'development') { - module.exports = { - ReactQueryDevtools: function () { - return null - }, - ReactQueryDevtoolsPanel: function () { - return null - }, - } -} else { - module.exports = require('./devtools') -} +export * from './devtools' From b0ee7f35c2e55a9ef38ff7ae71adf13a10e53786 Mon Sep 17 00:00:00 2001 From: Dominik Dorfmeister Date: Wed, 20 Jul 2022 16:23:05 +0200 Subject: [PATCH 12/12] fix(react-query-devtools): only export devtools in development mode add env check for cjs builds --- packages/react-query-devtools/src/index.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/packages/react-query-devtools/src/index.ts b/packages/react-query-devtools/src/index.ts index 39356ff2a4..81a5e16865 100644 --- a/packages/react-query-devtools/src/index.ts +++ b/packages/react-query-devtools/src/index.ts @@ -1 +1,15 @@ -export * from './devtools' +import * as devtools from './devtools' + +export const ReactQueryDevtools: typeof devtools['ReactQueryDevtools'] = + process.env.NODE_ENV !== 'development' + ? function () { + return null + } + : devtools.ReactQueryDevtools + +export const ReactQueryDevtoolsPanel: typeof devtools['ReactQueryDevtoolsPanel'] = + process.env.NODE_ENV !== 'development' + ? (function () { + return null + } as any) + : devtools.ReactQueryDevtoolsPanel