Skip to content

Commit 9f62187

Browse files
authored
Merge branch 'main' into test/use-suspense-query
2 parents cda32e8 + b1cdbc3 commit 9f62187

File tree

2 files changed

+140
-0
lines changed

2 files changed

+140
-0
lines changed

packages/react-query/src/__tests__/useSuspenseInfiniteQuery.test.tsx

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,72 @@ describe('useSuspenseInfiniteQuery', () => {
4646
)
4747
consoleErrorSpy.mockRestore()
4848
})
49+
50+
it('should log an error when skipToken is used in development environment', () => {
51+
const envCopy = process.env.NODE_ENV
52+
process.env.NODE_ENV = 'development'
53+
54+
const consoleErrorSpy = vi
55+
.spyOn(console, 'error')
56+
.mockImplementation(() => undefined)
57+
const key = queryKey()
58+
59+
function Page() {
60+
useSuspenseInfiniteQuery({
61+
queryKey: key,
62+
queryFn: skipToken as any,
63+
initialPageParam: 1,
64+
getNextPageParam: () => 1,
65+
})
66+
67+
return null
68+
}
69+
70+
renderWithClient(
71+
queryClient,
72+
<React.Suspense fallback="Loading...">
73+
<Page />
74+
</React.Suspense>,
75+
)
76+
77+
expect(consoleErrorSpy).toHaveBeenCalledWith(
78+
'skipToken is not allowed for useSuspenseInfiniteQuery',
79+
)
80+
81+
consoleErrorSpy.mockRestore()
82+
process.env.NODE_ENV = envCopy
83+
})
84+
85+
it('should not log an error when skipToken is used in production environment', () => {
86+
const envCopy = process.env.NODE_ENV
87+
process.env.NODE_ENV = 'production'
88+
89+
const consoleErrorSpy = vi
90+
.spyOn(console, 'error')
91+
.mockImplementation(() => undefined)
92+
const key = queryKey()
93+
94+
function Page() {
95+
useSuspenseInfiniteQuery({
96+
queryKey: key,
97+
queryFn: skipToken as any,
98+
initialPageParam: 1,
99+
getNextPageParam: () => 1,
100+
})
101+
102+
return null
103+
}
104+
105+
renderWithClient(
106+
queryClient,
107+
<React.Suspense fallback="Loading...">
108+
<Page />
109+
</React.Suspense>,
110+
)
111+
112+
expect(consoleErrorSpy).not.toHaveBeenCalled()
113+
114+
consoleErrorSpy.mockRestore()
115+
process.env.NODE_ENV = envCopy
116+
})
49117
})

packages/react-query/src/__tests__/useSuspenseQueries.test.tsx

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -713,4 +713,76 @@ describe('useSuspenseQueries 2', () => {
713713
)
714714
consoleErrorSpy.mockRestore()
715715
})
716+
717+
it('should log an error when skipToken is used in development environment', () => {
718+
const envCopy = process.env.NODE_ENV
719+
process.env.NODE_ENV = 'development'
720+
721+
const consoleErrorSpy = vi
722+
.spyOn(console, 'error')
723+
.mockImplementation(() => undefined)
724+
const key = queryKey()
725+
726+
function Page() {
727+
useSuspenseQueries({
728+
queries: [
729+
{
730+
queryKey: key,
731+
queryFn: skipToken as any,
732+
},
733+
],
734+
})
735+
736+
return null
737+
}
738+
739+
renderWithClient(
740+
queryClient,
741+
<React.Suspense fallback="Loading...">
742+
<Page />
743+
</React.Suspense>,
744+
)
745+
746+
expect(consoleErrorSpy).toHaveBeenCalledWith(
747+
'skipToken is not allowed for useSuspenseQueries',
748+
)
749+
750+
consoleErrorSpy.mockRestore()
751+
process.env.NODE_ENV = envCopy
752+
})
753+
754+
it('should not log an error when skipToken is used in production environment', () => {
755+
const envCopy = process.env.NODE_ENV
756+
process.env.NODE_ENV = 'production'
757+
758+
const consoleErrorSpy = vi
759+
.spyOn(console, 'error')
760+
.mockImplementation(() => undefined)
761+
const key = queryKey()
762+
763+
function Page() {
764+
useSuspenseQueries({
765+
queries: [
766+
{
767+
queryKey: key,
768+
queryFn: skipToken as any,
769+
},
770+
],
771+
})
772+
773+
return null
774+
}
775+
776+
renderWithClient(
777+
queryClient,
778+
<React.Suspense fallback="Loading...">
779+
<Page />
780+
</React.Suspense>,
781+
)
782+
783+
expect(consoleErrorSpy).not.toHaveBeenCalled()
784+
785+
consoleErrorSpy.mockRestore()
786+
process.env.NODE_ENV = envCopy
787+
})
716788
})

0 commit comments

Comments
 (0)