Skip to content

Commit 0c04e7d

Browse files
authored
fix(types): make sure queryClient.setQueriesData can return undefined from the updater (#3657)
1 parent 4a43068 commit 0c04e7d

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/core/queryClient.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,19 @@ export class QueryClient {
148148

149149
setQueriesData<TData>(
150150
queryKey: QueryKey,
151-
updater: Updater<TData | undefined, TData>,
151+
updater: Updater<TData | undefined, TData | undefined>,
152152
options?: SetDataOptions
153-
): [QueryKey, TData][]
153+
): [QueryKey, TData | undefined][]
154154

155155
setQueriesData<TData>(
156156
filters: QueryFilters,
157-
updater: Updater<TData | undefined, TData>,
157+
updater: Updater<TData | undefined, TData | undefined>,
158158
options?: SetDataOptions
159-
): [QueryKey, TData][]
159+
): [QueryKey, TData | undefined][]
160160

161161
setQueriesData<TData>(
162162
queryKeyOrFilters: QueryKey | QueryFilters,
163-
updater: Updater<TData | undefined, TData>,
163+
updater: Updater<TData | undefined, TData | undefined>,
164164
options?: SetDataOptions
165165
): [QueryKey, TData | undefined][] {
166166
return notifyManager.batch(() =>

src/core/tests/queryClient.test.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,8 @@ describe('queryClient', () => {
386386
queryClient.setQueryData(['key', 1], 1)
387387
queryClient.setQueryData(['key', 2], 2)
388388

389-
const result = queryClient.setQueriesData<number>(
390-
['key'],
391-
old => old! + 5
389+
const result = queryClient.setQueriesData<number>(['key'], old =>
390+
old ? old + 5 : undefined
392391
)
393392

394393
expect(result).toEqual([

0 commit comments

Comments
 (0)