Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Bullet point lists are not rendered in docs #128

Closed
mbrandonw opened this issue May 27, 2020 · 4 comments · Fixed by SwiftDocOrg/SwiftMarkup#3 or #130
Closed

Bullet point lists are not rendered in docs #128

mbrandonw opened this issue May 27, 2020 · 4 comments · Fixed by SwiftDocOrg/SwiftMarkup#3 or #130
Labels
bug Something isn't working design Functionality with a design component

Comments

@mbrandonw
Copy link
Contributor

We just started preparing to use swift-doc in our Composable Architecture repo, and so far it's looking really nice! We've found a couple of small bugs that we wanted to bring to your attention. I haven't seen this one reported yet.

The docs generated for this:

https://github.com/pointfreeco/swift-composable-architecture/blob/28c65dfa60ac8640b1d893746d8525213a054877/Sources/ComposableArchitecture/SwiftUI/WithViewStore.swift#L7-L18

looks like this:

https://github.com/pointfreeco/swift-composable-architecture/blob/28c65dfa60ac8640b1d893746d8525213a054877/Documentation/ComposableArchitecture/WithViewStore/index.html#L47-L50

In particular, the bullet points have been removed.

@mattt mattt added bug Something isn't working design Functionality with a design component labels May 27, 2020
@mattt
Copy link
Contributor

mattt commented May 27, 2020

Thanks for pointing this out, @mbrandonw! I know exactly what the problem is.

In the parser for SwiftMarkup, we walk bulleted list items to check for callouts like Important or Parameters. If no callout delimiters are found, the text gets returned, but minus the original *:

https://github.com/SwiftDocOrg/SwiftMarkup/blob/f395f3bd9e345402cc744aa9051780ed403d3b26/Sources/SwiftMarkup/Documentation.swift#L150

I should have a fix for that in swift-doc on master later today for you to use.

@mbrandonw
Copy link
Contributor Author

Awesome! Thanks @mattt.

Interested to see the fix! We're interested in learning more of the code so that we can help out.

@mattt
Copy link
Contributor

mattt commented May 27, 2020

@mbrandonw Alright, I just opened #130, which I believe should resolve this. I'll have time to verify this in a few days, but you're more than welcome to test this out for yourself locally.

@mbrandonw
Copy link
Contributor Author

Beautiful, pulled down that branch and ran TCA through and it works!

pointfreeco/swift-composable-architecture@1ded20b#diff-01f64672d601c10fb38c79f3598541b7R50-R64

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working design Functionality with a design component
Projects
None yet
2 participants