Skip to content

clean up for SL4 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2018
Merged

clean up for SL4 #21

merged 2 commits into from
Mar 26, 2018

Conversation

@braver
Copy link
Member

@braver braver commented Mar 25, 2018 •
edited
Loading

  • Remove outdated comments
  • Remove implementation that was already behind a version check
  • Start using selector

@braver braver requested a review from kaste March 25, 2018 16:43
kaste
kaste requested changes Mar 25, 2018
View reviewed changes
Copy link
Member

@kaste kaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary breaking to cut the defaults here.

@braver
Copy link
Member Author

braver commented Mar 26, 2018

Yeah I thought let’s see what you think here. Eventually I’d like to remove those too, but you’re right, let’s not break things right now.

@braver braver merged commit 88e7880 into master Mar 26, 2018
@kaste kaste deleted the sl4-cleanup branch July 13, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaste kaste kaste approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@braver @kaste