-
Notifications
You must be signed in to change notification settings - Fork 30
Disable memoization for specific requests #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
contesini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joaoantoniosouza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JustinTRoss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! 💪 This feature is dearly needed.
|
Is there anywhere we can find a list of maintainers who can approve the running of workflows? @StarpTech |
|
Hi @JustinTRoss, I'll try to review it next week. Thanks for the work. |
|
Thanks @StarpTech 🙏 . @rerinho is the hard-worker 🔨 . Just looking for the lever to advance this to the next step 🙃 . |
StarpTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a small thing. Great PR.
StarpTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello!
Changes:
GETrequests)memoisedResults.a. When no memoize option is informed (only for non-GET requests)
b. When memoize option is false (should not add the response in the
memoizedResults)c. When memoize option is true (current version default approach)
Motivation: