update QuickLRU option (2) #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shkaper
commented
Nov 16, 2021
Contributor
Author
|
Hey @StarpTech, have you got the chance to review this yet? |
StarpTech
requested changes
Dec 13, 2021
| super() | ||
| this.memoizedResults = new QuickLRU({ | ||
| maxSize: this.options?.lru?.maxSize ? this.options.lru.maxSize : 100, | ||
| maxAge: this.options?.lru?.maxAge, |
Owner
There was a problem hiding this comment.
Apollo works with seconds. Should we work with seconds too here?
|
Hi @shkaper and @StarpTech , we (The company I'm currently working) are in need of this feature as well. Can you merge this and update the package? |
Owner
|
Hi @thiagomini, the PR is reviewed, but the original author isn't responding. In the future, I recommend creating a separate PR with the changes. I'll handle it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #15, I've fixed the flaking test there. I think sinonjs FakeTimer is a more robust solution for a test where timeouts are involved.
Closes #14