Skip to content

Commit 8fac122

Browse files
authored
bpo-37321: Edit IDLE subprocess connection error messages. (python#14170)
Mainly, add a doc reference to message in pyshell.
1 parent 5bff3c8 commit 8fac122

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

Lib/idlelib/NEWS.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ Released on 2019-10-20?
33
======================================
44

55

6+
bpo-37321: Both subprocess connection error messages now refer to
7+
the 'Startup failure' section of the IDLE doc.
8+
69
bpo-37039: Adjust "Zoom Height" to individual screens by momemtarily
710
maximizing the window on first use with a particular screen. Changing
811
screen settings may invalidate the saved height. While a window is

Lib/idlelib/pyshell.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -824,10 +824,10 @@ def display_port_binding_error(self):
824824

825825
def display_no_subprocess_error(self):
826826
tkMessageBox.showerror(
827-
"Subprocess Startup Error",
828-
"IDLE's subprocess didn't make connection. Either IDLE can't "
829-
"start a subprocess or personal firewall software is blocking "
830-
"the connection.",
827+
"Subprocess Connection Error",
828+
"IDLE's subprocess didn't make connection.\n"
829+
"See the 'Startup failure' section of the IDLE doc, online at\n"
830+
"https://docs.python.org/3/library/idle.html#startup-failure",
831831
parent=self.tkconsole.text)
832832

833833
def display_executing_dialog(self):

Lib/idlelib/run.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,11 +199,13 @@ def show_socket_error(err, address):
199199
root = tkinter.Tk()
200200
fix_scaling(root)
201201
root.withdraw()
202-
msg = f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"\
203-
f"Fatal OSError #{err.errno}: {err.strerror}.\n"\
204-
f"See the 'Startup failure' section of the IDLE doc, online at\n"\
205-
f"https://docs.python.org/3/library/idle.html#startup-failure"
206-
showerror("IDLE Subprocess Error", msg, parent=root)
202+
showerror(
203+
"Subprocess Connection Error",
204+
f"IDLE's subprocess can't connect to {address[0]}:{address[1]}.\n"
205+
f"Fatal OSError #{err.errno}: {err.strerror}.\n"
206+
"See the 'Startup failure' section of the IDLE doc, online at\n"
207+
"https://docs.python.org/3/library/idle.html#startup-failure",
208+
parent=root)
207209
root.destroy()
208210

209211
def print_exception():
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Both subprocess connection error messages now refer to the 'Startup failure'
2+
section of the IDLE doc.

0 commit comments

Comments
 (0)