Unsubscribe not removing subscriptions made with ChannelMessageQueue Subscribe

[BrennanConroy]

ISubscriber.UnsubscribeAsync(channelName) does not unsubscribe subscriptions made with the new channel queue ISubscriber.SubscribeAsync(channelName).

var channel = await _bus.SubscribeAsync("name");
channel.OnMessage(channelMessage =>Task.CompletedTask);
await _bus.UnsubscribeAsync("name"); // does not unsubscribe

[mgravell]

Will look first thing tomorrow morning. Sorry for delay, was working on a stability fix.

[mgravell]

You're right, something isn't working quite right there; however! In this case, you don't need it - the following works as a workaround (and is the intended usage):

await channel.UnsubscribeAsync();

I'll make sure the other path gets fixed, though

[mgravell]

k; to explain what was happening here: we have two types of subscriptions - "things we trust not to steal our thread" (i.e. our own code, which includes the ChannelMessageQueue implementation), and "things we don't trust at all" (i.e. anything that used the older API). The most significant difference between them is that if we don't trust it not to steal the thread, we need to dispatch the callback to a worker. If we trust the code, we can just invoke it inline.

So: because the "old" API (taking a delegate directly) is the "untrusted" path, we push anything that uses it into the "untrusted" bucket; and indirectly, UnsubscribeAsync(channel, null) was also saying "this is the legacy API, you can't trust me!", so it was only clearing the untrusted bucket. When what it probably should do is: clear both buckets. The reason the workaround works is that it explicitly says "hey, I'm trusted", so it looks in the correct bucket.

So: fixed next deploy; since a workaround exists (above), I'm not pushing it as an "urgent"

[mgravell]

if you want a preview: r593 on myget

[mgravell]

and nuget: https://www.nuget.org/packages/StackExchange.Redis/2.0.593