feat: Added support for slider widget #97
Conversation
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Once again thanks for an amazing PR, @ishanvaghani 🎉. Please check my suggestions.
.vscode/launch.json
Outdated
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we please remove the launch.json file? For mirai I wish to keep the configuration file locally.
| MiraiSlider getModel(Map<String, dynamic> json) => MiraiSlider.fromJson(json); | ||
|
|
||
| @override | ||
| String get type => WidgetType.slider.name; |
There was a problem hiding this comment.
Can we please move the type method to come first, before the getModal method?
|
|
||
| Mirai circularProgressIndicator allows you to build the Flutter CircularProgressIndicator widget using JSON. | ||
| To know more about the container widget in Flutter, refer to the [official documentation](https://api.flutter.dev/flutter/material/CircularProgressIndicator-class.html). | ||
| To know more about the CircularProgressIndicator widget in Flutter, refer to the [official documentation](https://api.flutter.dev/flutter/material/CircularProgressIndicator-class.html). |
There was a problem hiding this comment.
Thanks for the correction 🙏🏻
website/docs/widgets/slider.md
Outdated
| | autofocus | `bool` | True if this widget will be selected as the initial focus when no other node in its scope is currently focused. | | ||
| | allowedInteraction | `SliderInteraction` | Allowed way for the user to interact with the slider. | | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you please remove the extra line?
|
Resolved all the comments |
website/docs/widgets/slider.md
Outdated
| | autofocus | `bool` | True if this widget will be selected as the initial focus when no other node in its scope is currently focused. | | ||
| | allowedInteraction | `SliderInteraction` | Allowed way for the user to interact with the slider. | | ||
|
|
||
|
|
There was a problem hiding this comment.
@ishanvaghani Can you check this one? I can still see 2 empty lines at line no. 29 & 30.
There was a problem hiding this comment.
Done removed one line
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Thank you for amazing work @ishanvaghani 💯
2 participants
Description
Added support for slider widget.
Added VS Code launch modes file.
Resolved mistakes in documentation.
Screenshots
XRecorder_09012025_211216.mp4
Related Issues
Issue not listed
Type of Change