feat: Added support for name colors #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyanshub024
requested changes
Jan 22, 2025
| } | ||
|
|
||
| Color? _parseNameColor(String colorString) { | ||
| // 3 digits shade - Ex: yellow200 |
Member
There was a problem hiding this comment.
@ishanvaghani We don't need shades for all colors. The material color shades provided in black and white colors are good enough.
Contributor
Author
There was a problem hiding this comment.
I think it will be add-on to define color shades. If you think it's unnecessary i will remove it
Member
There was a problem hiding this comment.
I think only a small fraction of people might use it, but it could add unnecessary complexity for those new to Mirai. Initially, we should keep things simple and consider adding it later if the need comes.
Contributor
Author
There was a problem hiding this comment.
Removed shades from colors except black and white
| case MiraiColors.amberAccent: | ||
| return Colors.amberAccent[shadeInt]; | ||
| case MiraiColors.black: | ||
| switch (shadeInt) { |
divyanshub024
approved these changes
Jan 23, 2025
Member
divyanshub024
left a comment
divyanshub024
left a comment
There was a problem hiding this comment.
Great work @ishanvaghani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #123
Type of Change