Skip to content

Fix overflow in MemoryAllocator.Create(options) #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2024
Merged

Fix overflow in MemoryAllocator.Create(options) #2730

merged 3 commits into from
May 8, 2024
+17 −1

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented May 7, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fix an overlook from #2706. See 92b8277#r141770676.

antonfirsov referenced this pull request May 7, 2024
@antonfirsov
Limit all allocations
92b8277
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented May 7, 2024

Thanks! We should probably backport this.

@antonfirsov
Copy link
Member Author

antonfirsov commented May 8, 2024

We should probably backport this.

Agreed. The bug renders the AllocationLimitMegabytes API pretty useless when it comes to extending the limit.

@antonfirsov antonfirsov merged commit 467850f into main May 8, 2024
@antonfirsov antonfirsov deleted the af/fix-allocator-overflow branch May 8, 2024 16:01
antonfirsov added a commit that referenced this pull request May 8, 2024
@antonfirsov
Fix overflow in MemoryAllocator.Create(options) (#2730)
7d3f852 
Fix an overlook from #2706. See 92b8277#r141770676.
antonfirsov added a commit that referenced this pull request May 8, 2024
@antonfirsov
Fix overflow in MemoryAllocator.Create(options) (#2730)
7386702 
Fix an overlook from #2706. See 92b8277#r141770676.
# Conflicts:
#	src/ImageSharp/Memory/Allocators/MemoryAllocator.cs
This was referenced May 8, 2024
Merged
Merged
@jetelain jetelain mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonfirsov @JimBobSquarePants