From e2140381949d58337d6e0ba88db94f78d46e7ec2 Mon Sep 17 00:00:00 2001 From: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:38:59 +0100 Subject: [PATCH 1/4] ci/macos: use github macos-14 - similar to eigenpy: https://github.com/stack-of-tasks/eigenpy/pull/439/files --- .github/workflows/ci-linux-osx-win-conda.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-linux-osx-win-conda.yml b/.github/workflows/ci-linux-osx-win-conda.yml index f10e0a3bf..61cfb6337 100644 --- a/.github/workflows/ci-linux-osx-win-conda.yml +++ b/.github/workflows/ci-linux-osx-win-conda.yml @@ -13,7 +13,7 @@ jobs: fail-fast: false matrix: build_type: [Release, Debug] - name: [ubuntu-latest, macos-latest, windows-2019-clang-cl, windows-latest] + name: [ubuntu-latest, macos-latest, windows-2019-clang-cl, windows-latest, macos-14] cxx_std: [17, 20] continue_on_error: [false] @@ -22,6 +22,8 @@ jobs: os: ubuntu-latest - name: macos-latest os: macos-latest + - name: macos-14 + os: macos-14 - name: windows-2019-clang-cl os: windows-2019 compiler: clang-cl @@ -56,6 +58,7 @@ jobs: - uses: actions/checkout@v2 - uses: conda-incubator/setup-miniconda@v2 + if: matrix.os != 'macos-14' with: miniforge-variant: Mambaforge miniforge-version: latest @@ -63,6 +66,14 @@ jobs: python-version: "3.10" activate-environment: proxsuite + - uses: conda-incubator/setup-miniconda@v3 + if: matrix.os == 'macos-14' + with: + channels: conda-forge + python-version: "3.10" + activate-environment: proxsuite + installer-url: https://github.com/conda-forge/miniforge/releases/download/23.11.0-0/Mambaforge-23.11.0-0-MacOSX-arm64.sh + - name: Install dependencies [Conda] shell: bash -l {0} run: | From d9025f4463465798d099c5df929ee559bcec03ef Mon Sep 17 00:00:00 2001 From: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Date: Wed, 6 Mar 2024 16:39:55 +0100 Subject: [PATCH 2/4] remove self-hosted macos-14 ci --- .github/workflows/ci-osx-arm64-conda.yml | 88 ------------------------ 1 file changed, 88 deletions(-) delete mode 100644 .github/workflows/ci-osx-arm64-conda.yml diff --git a/.github/workflows/ci-osx-arm64-conda.yml b/.github/workflows/ci-osx-arm64-conda.yml deleted file mode 100644 index 81b935b3a..000000000 --- a/.github/workflows/ci-osx-arm64-conda.yml +++ /dev/null @@ -1,88 +0,0 @@ -name: CI - OSX ARM64 - Conda - -on: - push: - pull_request: - -env: - PYTHONPATH: ${CONDA_PREFIX}/lib/python3.8/site-packages/ - -jobs: - build-with-conda: - name: '[conda:${{ matrix.os }}:${{ matrix.build_type }}]' - runs-on: ${{ matrix.os }} - strategy: - fail-fast: false - matrix: - build_type: [Release, Debug] - name: [macos-m1] - - include: - - name: macos-m1 - os: self-hosted-arm64 - - steps: - - uses: actions/checkout@v2 - - # not working due to The node12 is not supported on macOS ARM64 platform. Use node16 instead. - # open issue https://github.com/conda-incubator/setup-miniconda/issues/247 - # - uses: conda-incubator/setup-miniconda@v2 - # with: - # activate-environment: proxarm - - - name: Environment - shell: bash -l {0} - run: | - echo $CONDA_PREFIX - conda info - conda list - env - - - name: Configure - shell: bash -l {0} - run: | - cd $GITHUB_WORKSPACE - git submodule update --init - mkdir build - cd build - cmake .. -GNinja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DBUILD_PYTHON_INTERFACE:BOOL=ON -DBUILD_WITH_VECTORIZATION_SUPPORT:BOOL=OFF -DPYTHON_SITELIB=${CONDA_PREFIX}/Lib/site-packages -DPYTHON_EXECUTABLE=${CONDA_PYTHON_EXE} -DBUILD_DOCUMENTATION:BOOL=ON -DINSTALL_DOCUMENTATION:BOOL=ON -DTEST_JULIA_INTERFACE:BOOL=OFF - - - name: Build - shell: bash -l {0} - run: | - cd $GITHUB_WORKSPACE/build - cmake --build . --config ${{ matrix.build_type }} -v - - - name: Install - shell: bash -l {0} - run: | - cd $GITHUB_WORKSPACE/build - cmake --install . --config ${{ matrix.build_type }} - - - - name: Test - shell: bash -l {0} - run: | - cd $GITHUB_WORKSPACE/build - ctest --output-on-failure -C ${{ matrix.build_type }} - - - - name: Uninstall [Conda] - shell: bash -l {0} - run: | - cd $GITHUB_WORKSPACE/build - cmake --build . --config ${{ matrix.build_type }} --target uninstall - - check: - if: always() - name: check-ci-osx-arm64-conda - - needs: - - build-with-conda - - runs-on: Ubuntu-latest - steps: - - name: Decide whether the needed jobs succeeded or failed - uses: re-actors/alls-green@release/v1 - with: - jobs: ${{ toJSON(needs) }} \ No newline at end of file From dae2d3b807d1ed5f3b72e854c2f09f0b277138e4 Mon Sep 17 00:00:00 2001 From: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Date: Wed, 6 Mar 2024 17:06:01 +0100 Subject: [PATCH 3/4] update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cdaa5f6c8..0df6d85c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] +### What's Changed +* Switch from self-hosted runner for macos-14-ARM to runner from github ([#306](https://github.com/Simple-Robotics/proxsuite/pull/306)) + ## [0.6.4] - 2024-03-01 ### What's Changed From c193f84171c4b9bb867ce9a7ad8ea672357fb647 Mon Sep 17 00:00:00 2001 From: Fabian Schramm <55981657+fabinsch@users.noreply.github.com> Date: Wed, 6 Mar 2024 17:32:47 +0100 Subject: [PATCH 4/4] ci/macos-14: do not test julia example --- .github/workflows/ci-linux-osx-win-conda.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-linux-osx-win-conda.yml b/.github/workflows/ci-linux-osx-win-conda.yml index 61cfb6337..ea21da8b4 100644 --- a/.github/workflows/ci-linux-osx-win-conda.yml +++ b/.github/workflows/ci-linux-osx-win-conda.yml @@ -87,7 +87,7 @@ jobs: mamba install libmatio numpy scipy - name: Install julia [macOS/Linux] - if: contains(matrix.os, 'macos') || contains(matrix.os, 'ubuntu') + if: contains(matrix.os, 'macos-latest') || contains(matrix.os, 'ubuntu') shell: bash -l {0} run: | mamba install julia @@ -106,7 +106,7 @@ jobs: env - name: Configure [Conda/Linux&macOS] - if: contains(matrix.os, 'macos') || contains(matrix.os, 'ubuntu') + if: contains(matrix.os, 'macos-latest') || contains(matrix.os, 'ubuntu') shell: bash -l {0} run: | echo $(whereis ccache) @@ -116,8 +116,20 @@ jobs: cd build cmake .. -GNinja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_STANDARD=${{ matrix.cxx_std }} -DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DBUILD_PYTHON_INTERFACE:BOOL=ON -DPYTHON_EXECUTABLE=$(which python3) -DBUILD_DOCUMENTATION:BOOL=ON -DINSTALL_DOCUMENTATION:BOOL=ON -DTEST_JULIA_INTERFACE:BOOL=ON -DOpenMP_ROOT=$CONDA_PREFIX + - name: Configure [Conda/macOS14] + if: contains(matrix.os, 'macos-14') + shell: bash -l {0} + run: | + echo $(whereis ccache) + echo $(which ccache) + git submodule update --init + mkdir build + cd build + cmake .. -GNinja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_STANDARD=${{ matrix.cxx_std }} -DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DBUILD_PYTHON_INTERFACE:BOOL=ON -DPYTHON_EXECUTABLE=$(which python3) -DBUILD_DOCUMENTATION:BOOL=ON -DINSTALL_DOCUMENTATION:BOOL=ON -DTEST_JULIA_INTERFACE:BOOL=OFF -DOpenMP_ROOT=$CONDA_PREFIX + + - name: Configure [Conda/macOS-debug/CheckMalloc] - if: contains(matrix.os, 'macos') && contains(matrix.build_type, 'Debug') + if: contains(matrix.os, 'macos-latest') && contains(matrix.build_type, 'Debug') shell: bash -l {0} run: | echo $(whereis ccache)