Define PROXSUITE_AS_SUBPROJECT as ON #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
Member
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
|
|
As-is, at least on CMake 3.25, `set(PROXSUITE_AS_SUBPROJECT)` does not cause it to evaluate as true in the below tests Topic: proxsuite-as-subproject
amiller27
force-pushed
the
acmiller273/revup/main/proxsuite-as-subproject
branch
from
752ed86 to
fdf3450
Compare
jcarpent
approved these changes
Apr 2, 2023
jcarpent
approved these changes
Apr 2, 2023
Member
jcarpent
left a comment
jcarpent
left a comment
There was a problem hiding this comment.
Thanks @amiller27 for this very helpful fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, at least on CMake 3.25,
set(PROXSUITE_AS_SUBPROJECT)does notcause it to evaluate as true in the below tests
Topic: proxsuite-as-subproject