Commit dc2990a
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
### WHY are these changes introduced?
Part of #7212 <!-- link to issue if one exists -->
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
Adding more functionality to the `replace-spacing-lengths` migration
script.
Running ```npx @shopify/polaris-migrator replace-spacing-lengths
"**/*.scss"``` will now also target the following `gap` properties and
replace any `px`, `rem` or `rem()` values that align with our [spacing
tokens](https://github.com/Shopify/polaris/blob/a192e3641a8629a2ea9e1a1bd5d6c20aaf9a499c/polaris-tokens/src/token-groups/spacing.ts).
- `gap`
- `grid-gap`
- `row-gap`
- `grid-row-gap`
- `column-gap`
- `grid-column-gap`
Co-Authored-By: Chloe Rice <[email protected]>
Co-authored-by: Chloe Rice <[email protected]>
Co-authored-by: Chloe Rice <[email protected]>
Co-authored-by: Aaron Casanova <[email protected]>
1 parent 6228875 commit dc2990a
File tree
12 files changed
+503
-422
lines changed- .changeset
- polaris-migrator
- src
- migrations
- replace-sass-lengths
- tests
- replace-spacing-lengths
- tests
- utilities
12 files changed
+503
-422
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
52 | 71 | | |
53 | 72 | | |
54 | 73 | | |
| |||
Lines changed: 0 additions & 120 deletions
This file was deleted.
Lines changed: 0 additions & 80 deletions
This file was deleted.
Lines changed: 0 additions & 81 deletions
This file was deleted.
0 commit comments