From 80024894c146ae2116965318a3062f336a152db9 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 31 Jul 2025 14:20:24 +0200 Subject: [PATCH 1/3] Enabling two FF driver tests --- examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs b/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs index fc792c3eb8f4..de84931de549 100644 --- a/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs +++ b/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs @@ -56,11 +56,10 @@ public void SetBinary() } [TestMethod] - [Ignore("Not implemented")] public void LogsToFile() { var service = FirefoxDriverService.CreateDefaultService(); - //service.LogFile = _logLocation + service.LogPath = GetLogLocation(); driver = new FirefoxDriver(service); var lines = File.ReadLines(GetLogLocation()); @@ -85,12 +84,10 @@ public void LogsToConsole() } [TestMethod] - [Ignore("You can set it, just can't see it")] public void LogsLevel() { var service = FirefoxDriverService.CreateDefaultService(); - //service.LogFile = _logLocation - + service.LogPath = GetLogLocation(); service.LogLevel = FirefoxDriverLogLevel.Debug; driver = new FirefoxDriver(service); @@ -171,7 +168,7 @@ public void InstallUnsignedAddon() private string GetLogLocation() { - if (_logLocation != null && !File.Exists(_logLocation)) + if (string.IsNullOrEmpty(_logLocation) && !File.Exists(_logLocation)) { _logLocation = Path.GetTempFileName(); } From 7eb3a10a86a65cca681335b4027011bceaccb090 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 31 Jul 2025 14:43:33 +0200 Subject: [PATCH 2/3] Quitting the driver to release the lock on the log file. --- examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs b/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs index de84931de549..0b7e127b6f40 100644 --- a/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs +++ b/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs @@ -25,7 +25,13 @@ public void Cleanup() { File.Delete(_tempPath); } - driver.Quit(); + try + { + driver.Quit(); + } + catch (WebDriverException) + { + } } [TestMethod] @@ -62,6 +68,7 @@ public void LogsToFile() service.LogPath = GetLogLocation(); driver = new FirefoxDriver(service); + driver.Quit(); var lines = File.ReadLines(GetLogLocation()); Assert.IsNotNull(lines.FirstOrDefault(line => line.Contains("geckodriver INFO Listening on"))); } @@ -91,6 +98,7 @@ public void LogsLevel() service.LogLevel = FirefoxDriverLogLevel.Debug; driver = new FirefoxDriver(service); + driver.Quit(); var lines = File.ReadLines(GetLogLocation()); Assert.IsNotNull(lines.FirstOrDefault(line => line.Contains("Marionette\tDEBUG"))); } From 82705e2788da9f7d48a82a3d529664e0e55af741 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 12 Aug 2025 20:33:06 +0200 Subject: [PATCH 3/3] Running website test script only when site changes. --- .github/workflows/test.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e92e293f41ee..a4d3ec94bcbf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,9 +4,13 @@ on: pull_request: branches: - trunk + paths: + - 'website_and_docs/**' push: branches: - trunk + paths: + - 'website_and_docs/**' jobs: test_build: