whack-a-mole

Author: shbenzer

examples/java/src/test/java/dev/selenium/design_strategies/EditIssue.java

@@ -57,10 +57,10 @@ public void setUsingGrid(String usingGrid) {
     clearAndType(field, usingGrid);
   }
 
-  public IssueList submit() {
-    driver.findElement(By.cssSelector("button[type='submit']")).click();
-    return new IssueList(driver);
-  }
+  // public IssueList submit() {
+  //   driver.findElement(By.cssSelector("button[type='submit']")).click();
+  //   return new IssueList(driver);
+  // }
 
   private void clearAndType(WebElement field, String text) {
     field.clear();

examples/java/src/test/java/dev/selenium/design_strategies/EditIssueBetter.java

@@ -5,7 +5,7 @@
 import org.openqa.selenium.support.FindBy;
 import org.openqa.selenium.support.PageFactory;
 
-import static junit.framework.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class EditIssueBetter extends EditIssue {
 
@@ -21,7 +21,7 @@ public class EditIssueBetter extends EditIssue {
   @FindBy(id = "issue_body") private WebElement body;
 
   public EditIssueBetter(WebDriver driver) {
-    this.driver = driver;
+    super(driver);
 
     // This call sets the WebElement fields.
     PageFactory.initElements(driver, this);

examples/java/src/test/java/dev/selenium/design_strategies/ProjectPage.java

@@ -2,9 +2,9 @@
 
 import org.openqa.selenium.WebDriver;
 
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class ProjectPage extends LoadableComponent<ProjectPage> {
+public class ProjectPage {
 
   private final WebDriver driver;
   private final String projectName;
@@ -14,12 +14,12 @@ public ProjectPage(WebDriver driver, String projectName) {
     this.projectName = projectName;
   }
 
-  @Override
+  
   protected void load() {
     driver.get("http://" + projectName + ".googlecode.com/");
   }
 
-  @Override
+  
   protected void isLoaded() throws Error {
     String url = driver.getCurrentUrl();
 

examples/java/src/test/java/dev/selenium/design_strategies/SecuredPage.java

@@ -7,21 +7,21 @@
 
 import static org.junit.Assert.fail;
 
-public class SecuredPage extends LoadableComponent<SecuredPage> {
+public class SecuredPage{
 
   private final WebDriver driver;
   private final LoadableComponent<?> parent;
   private final String username;
   private final String password;
 
-  public SecuredPage(WebDriver driver, LoadableComponent<?> parent, String username, String password) {
+  public SecuredPage(WebDriver driver, String username, String password) {
     this.driver = driver;
     this.parent = parent;
     this.username = username;
     this.password = password;
   }
 
-  @Override
+  
   protected void load() {
     parent.get();
 
@@ -38,7 +38,7 @@ protected void load() {
     driver.get(originalUrl);
   }
 
-  @Override
+  
   protected void isLoaded() throws Error {
     // If you're signed in, you have the option of picking a different login.
     // Let's check for the presence of that.