Skip to content

[dotnet] Fix name collisions for commands/responses/eventargs #15193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 1 commit into from
Jan 30, 2025
Merged

[dotnet] Fix name collisions for commands/responses/eventargs #15193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions third_party/dotnet/devtools/NuGet.Config
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions third_party/dotnet/devtools/src/generator/CodeGen/CommandInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ public sealed class CommandInfo(string commandName, string fullTypeName, string

public string FullTypeName { get; } = fullTypeName;

public string FullSnakeTypeName { get; } = fullTypeName.Replace(".", "_");

public string FullResponseTypeName { get; } = fullResponseTypeName;

public string FullSnakeResponseTypeName { get; } = fullResponseTypeName.Replace(".", "_");
}
}
2 changes: 2 additions & 0 deletions third_party/dotnet/devtools/src/generator/CodeGen/EventInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ public sealed class EventInfo(string eventName, string fullTypeName)
public string EventName { get; } = eventName;

public string FullTypeName { get; } = fullTypeName;

public string FullSnakeTypeName { get; } = fullTypeName.Replace(".", "_");
}
}
6 changes: 3 additions & 3 deletions third_party/dotnet/devtools/src/generator/Templates/DevToolsSessionDomains.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ namespace {{rootNamespace}}
}

{{#each commands}}
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{FullTypeName}}))]
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{FullResponseTypeName}}))]
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{FullTypeName}}), TypeInfoPropertyName = "{{FullSnakeTypeName}}")]
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{FullResponseTypeName}}), TypeInfoPropertyName = "{{FullSnakeResponseTypeName}}")]
{{/each}}
{{#each events}}
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{fullTypeName}}))]
[global::System.Text.Json.Serialization.JsonSerializable(typeof({{FullTypeName}}), TypeInfoPropertyName = "{{FullSnakeTypeName}}")]
{{/each}}
[global::System.Text.Json.Serialization.JsonSourceGenerationOptions(Converters = [typeof(OpenQA.Selenium.DevTools.Json.StringConverter)])]
internal sealed partial class {{protocolVersion}}JsonSerializerContext : global::System.Text.Json.Serialization.JsonSerializerContext;
Expand Down