Skip to content

Excluding windows api from portmacro.h and adding it to port.c #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Excluding windows api from portmacro.h and adding it to port.c #1

merged 1 commit into from
Apr 1, 2025

Conversation

@jauhersaeed
Copy link

@jauhersaeed jauhersaeed commented Apr 1, 2025

Jira Ticket

Design Notes

  • change is required to avoid yeild() defined as macro in freertos-addons when using MINGW port. Its better to have the required windows header files in port.c rather than in portmacro.h

Testing

  • No change is required in freertos-adons thread.hpp for this code compiles and runs successfully on windows now

Related PRs

@jauhersaeed
excluding windows api from portmacro.h and adding it to port.c to avo…
1973533 
…id yeild() defined as macro in freertos-addons
@gkhan-selectronic gkhan-selectronic self-requested a review April 1, 2025 03:23
@gkhan-selectronic gkhan-selectronic merged commit b942fda into main Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkhan-selectronic gkhan-selectronic gkhan-selectronic approved these changes

@iridley-selectronic iridley-selectronic iridley-selectronic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jauhersaeed @gkhan-selectronic @iridley-selectronic