Skip to content

Thermal sensors need outputs #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbatteh opened this issue Apr 16, 2025 · 1 comment
Open

Thermal sensors need outputs #384

jbatteh opened this issue Apr 16, 2025 · 1 comment

Comments

@jbatteh
Copy link
Contributor

jbatteh commented Apr 16, 2025

Is your feature request related to a problem? Please describe.

The sensor components in the MTK Thermal library do not have output connectors. Thus they cannot be wired to other components as expected (i.e. PID, etc.). This request applies to TemperatureSensor, RelativeTemperatureSensor, and HeatFlowSensor.

Describe the solution you’d like

The sensed variables should be added to a RealOutput component.

Describe alternatives you’ve considered

A clear and concise description of any alternative solutions or features you’ve considered.

Additional context

For reference, you can look at Modelica Standard Library (i.e. Modelica.Thermal.HeatTransfer.Sensors.TemperatureSensor)

jbatteh added a commit to jbatteh/ModelingToolkitStandardLibrary.jl that referenced this issue Apr 24, 2025
Using RealOutputs for thermal sensors.
Removing usage of OrdinaryDiffEqDefaults in tests
@bavcol
Copy link

bavcol commented Apr 25, 2025

When using the sensor components of MTK Electrical, I noticed those are missing the output port as well.
If I find the time, I will create a pull request for those as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants