Skip to content

[tsconfig] Update for TypeScript 5.8 #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperupcall merged 4 commits into from
Mar 6, 2025
Merged

[tsconfig] Update for TypeScript 5.8 #4503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a754008
[tsconfig] Update for TypeScript 5.8
andrewbranch Feb 27, 2025
3d8e6ef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 27, 2025
0b820de
Add `rewriteRelativeImportExtensions`
andrewbranch Feb 27, 2025
0411635
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/schemas/json/jsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,12 @@
"type": ["boolean", "null"],
"markdownDescription": "Enforces using indexed accessors for keys declared using an indexed type\n\nSee more: https://www.typescriptlang.org/tsconfig#noPropertyAccessFromIndexSignature"
},
"erasableSyntaxOnly": {
"description": "Do not allow runtime constructs that are not part of ECMAScript.",
Comment on lines +294 to +295
Copy link
Contributor

@jakebailey jakebailey Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all should be matching the declarations around it, e.g. the $comment is missing. (Same with the other options added in the PR)

Copy link
Contributor Author

@andrewbranch andrewbranch Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t really know what $comment is for, and lots of newer property declarations don’t have it 🤷

"type": ["boolean", "null"],
"default": false,
"markdownDescription": "Do not allow runtime constructs that are not part of ECMAScript.\n\nSee more: https://www.typescriptlang.org/tsconfig#erasableSyntaxOnly"
},
"emitBOM": {
"$comment": "The value of 'null' is UNDOCUMENTED (https://github.com/microsoft/TypeScript/pull/18058).",
"description": "Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files.",
Expand Down Expand Up @@ -406,12 +412,13 @@
"None",
"ES2022",
"Node16",
"Node18",
"NodeNext",
"Preserve"
]
},
{
"pattern": "^([Cc][Oo][Mm][Mm][Oo][Nn][Jj][Ss]|[AaUu][Mm][Dd]|[Ss][Yy][Ss][Tt][Ee][Mm]|[Ee][Ss]([356]|20(1[567]|2[02])|[Nn][Ee][Xx][Tt])|[Nn][Oo][dD][Ee]16|[Nn][Oo][Dd][Ee][Nn][Ee][Xx][Tt]|[Nn][Oo][Nn][Ee]|[Pp][Rr][Ee][Ss][Ee][Rr][Vv][Ee])$"
"pattern": "^([Cc][Oo][Mm][Mm][Oo][Nn][Jj][Ss]|[AaUu][Mm][Dd]|[Ss][Yy][Ss][Tt][Ee][Mm]|[Ee][Ss]([356]|20(1[567]|2[02])|[Nn][Ee][Xx][Tt])|[Nn][Oo][dD][Ee]1[68]|[Nn][Oo][Dd][Ee][Nn][Ee][Xx][Tt]|[Nn][Oo][Nn][Ee]|[Pp][Rr][Ee][Ss][Ee][Rr][Vv][Ee])$"
}
],
"markdownDescription": "Specify what module code is generated.\n\nSee more: https://www.typescriptlang.org/tsconfig#module"
Expand Down Expand Up @@ -594,6 +601,12 @@
"default": false,
"markdownDescription": "Disable emitting comments.\n\nSee more: https://www.typescriptlang.org/tsconfig#removeComments"
},
"rewriteRelativeImportExtensions": {
"description": "Rewrite '.ts', '.tsx', '.mts', and '.cts' file extensions in relative import paths to their JavaScript equivalent in output files.",
"type": ["boolean", "null"],
"default": false,
"markdownDescription": "Rewrite '.ts', '.tsx', '.mts', and '.cts' file extensions in relative import paths to their JavaScript equivalent in output files.\n\nSee more: https://www.typescriptlang.org/tsconfig#rewriteRelativeImportExtensions"
},
"rootDir": {
"$comment": "The value of 'null' is UNDOCUMENTED (https://github.com/microsoft/TypeScript/pull/18058).",
"description": "Specify the root folder within your source files.",
Expand Down Expand Up @@ -1052,6 +1065,12 @@
},
"markdownDescription": "Specify a set of bundled library declaration files that describe the target runtime environment.\n\nSee more: https://www.typescriptlang.org/tsconfig#lib"
},
"libReplacement": {
"description": "Enable lib replacement.",
"type": ["boolean", "null"],
"default": true,
"markdownDescription": "Enable lib replacement.\n\nSee more: https://www.typescriptlang.org/tsconfig#libReplacement"
},
"strictNullChecks": {
"$comment": "The value of 'null' is UNDOCUMENTED (https://github.com/microsoft/TypeScript/pull/18058).",
"description": "When type checking, take into account `null` and `undefined`.",
Expand Down
21 changes: 20 additions & 1 deletion src/schemas/json/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,12 @@
"default": false,
"markdownDescription": "Only output d.ts files and not JavaScript files.\n\nSee more: https://www.typescriptlang.org/tsconfig#emitDeclarationOnly"
},
"erasableSyntaxOnly": {
"description": "Do not allow runtime constructs that are not part of ECMAScript.",
"type": ["boolean", "null"],
"default": false,
"markdownDescription": "Do not allow runtime constructs that are not part of ECMAScript.\n\nSee more: https://www.typescriptlang.org/tsconfig#erasableSyntaxOnly"
},
"exactOptionalPropertyTypes": {
"$comment": "The value of 'null' is UNDOCUMENTED (https://github.com/microsoft/TypeScript/pull/18058).",
"description": "Differentiate between undefined and not present when type checking",
Expand Down Expand Up @@ -409,12 +415,13 @@
"None",
"ES2022",
"Node16",
"Node18",
"NodeNext",
"Preserve"
]
},
{
"pattern": "^([Cc][Oo][Mm][Mm][Oo][Nn][Jj][Ss]|[AaUu][Mm][Dd]|[Ss][Yy][Ss][Tt][Ee][Mm]|[Ee][Ss]([356]|20(1[567]|2[02])|[Nn][Ee][Xx][Tt])|[Nn][Oo][dD][Ee]16|[Nn][Oo][Dd][Ee][Nn][Ee][Xx][Tt]|[Nn][Oo][Nn][Ee]|[Pp][Rr][Ee][Ss][Ee][Rr][Vv][Ee])$"
"pattern": "^([Cc][Oo][Mm][Mm][Oo][Nn][Jj][Ss]|[AaUu][Mm][Dd]|[Ss][Yy][Ss][Tt][Ee][Mm]|[Ee][Ss]([356]|20(1[567]|2[02])|[Nn][Ee][Xx][Tt])|[Nn][Oo][dD][Ee]1[68]|[Nn][Oo][Dd][Ee][Nn][Ee][Xx][Tt]|[Nn][Oo][Nn][Ee]|[Pp][Rr][Ee][Ss][Ee][Rr][Vv][Ee])$"
}
],
"markdownDescription": "Specify what module code is generated.\n\nSee more: https://www.typescriptlang.org/tsconfig#module"
Expand Down Expand Up @@ -598,6 +605,12 @@
"default": false,
"markdownDescription": "Disable emitting comments.\n\nSee more: https://www.typescriptlang.org/tsconfig#removeComments"
},
"rewriteRelativeImportExtensions": {
"description": "Rewrite '.ts', '.tsx', '.mts', and '.cts' file extensions in relative import paths to their JavaScript equivalent in output files.",
"type": ["boolean", "null"],
"default": false,
"markdownDescription": "Rewrite '.ts', '.tsx', '.mts', and '.cts' file extensions in relative import paths to their JavaScript equivalent in output files.\n\nSee more: https://www.typescriptlang.org/tsconfig#rewriteRelativeImportExtensions"
},
"rootDir": {
"$comment": "The value of 'null' is UNDOCUMENTED (https://github.com/microsoft/TypeScript/pull/18058).",
"description": "Specify the root folder within your source files.",
Expand Down Expand Up @@ -1056,6 +1069,12 @@
},
"markdownDescription": "Specify a set of bundled library declaration files that describe the target runtime environment.\n\nSee more: https://www.typescriptlang.org/tsconfig#lib"
},
"libReplacement": {
"description": "Enable lib replacement.",
"type": ["boolean", "null"],
"default": true,
"markdownDescription": "Enable lib replacement.\n\nSee more: https://www.typescriptlang.org/tsconfig#libReplacement"
},
"moduleDetection": {
"description": "Specify how TypeScript determine a file as module.",
"enum": ["auto", "legacy", "force"]
Expand Down
7 changes: 7 additions & 0 deletions src/test/jsconfig/jsconfig-typescript5.8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"compilerOptions": {
"erasableSyntaxOnly": true,
"libReplacement": true,
"module": "node18"
}
}
1 change: 1 addition & 0 deletions src/test/tsconfig/tsconfig-typescript5.7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"es2024.sharedmemory",
"es2024.string"
],
"rewriteRelativeImportExtensions": true,
"target": "es2024"
}
}
7 changes: 7 additions & 0 deletions src/test/tsconfig/tsconfig-typescript5.8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"compilerOptions": {
"erasableSyntaxOnly": true,
"libReplacement": true,
"module": "node18"
}
}