Skip to content

Conversation

@d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-473

@coveralls
Copy link

coveralls commented Dec 6, 2022

Coverage Status

Coverage increased (+0.2%) to 94.916% when pulling 456e2c8 on specVersion-3.0 into 2c0ef1a on main.

@d3xter666 d3xter666 changed the title [DRAFT] specVersion 3.0 [INTERNAL] specVersion 3.0 Dec 9, 2022
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests for changes in specVersion 3.0 missing

@d3xter666
Copy link
Contributor Author

New tests for changes in specVersion 3.0 missing

There are now tests to cover the new/modified properties

@d3xter666 d3xter666 requested a review from matz3 December 13, 2022 13:51
@d3xter666 d3xter666 requested a review from matz3 December 15, 2022 06:52
@flovogt
Copy link
Member

flovogt commented Dec 15, 2022

LGTM

@matz3
Copy link
Member

matz3 commented Dec 19, 2022

LGTM. Please use the [FEATURE] tag for title and commit message.

@d3xter666 d3xter666 merged commit c5070e5 into main Dec 20, 2022
@d3xter666 d3xter666 deleted the specVersion-3.0 branch December 20, 2022 09:11
@matz3 matz3 changed the title [INTERNAL] specVersion 3.0 [FEATURE] specVersion 3.0 Dec 20, 2022
d3xter666 added a commit that referenced this pull request Feb 7, 2023
Adds schema support for UI5 Tooling v3
d3xter666 added a commit to UI5/cli that referenced this pull request Sep 25, 2025
Adds schema support for UI5 Tooling v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants