Fix JSX comment duplication in preserve mode #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where comments adjacent to JSX expressions were duplicated in the emitted output when using
jsx: preserve
mode.Problem
When JSX contains comments immediately before or after expressions, TypeScript was emitting those comments twice:
Root Cause
The issue occurred because comments in JSX content are parsed as both:
JsxText
with content"/*pre*/"
)This caused the same comment content to be emitted twice:
emitJsxText()
emitTokenWithComment()
Solution
The fix prevents duplicate comment emission by:
isEmittingJsxChildren
flag to track when we're emitting JSX element childrenemitTokenWithComment()
to skip leading/trailing comment emission for JSX expressions when they would duplicate JSX text contentTesting
Added comprehensive test case covering:
<div>/*pre*/{x}/*post*/</div>
<App>/* no */{/* 1 */ 123 /* 2 */}/* no */</App>
The fix works for both
jsx: preserve
andjsx: react-jsxdev
modes.Addressing #11.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.