Skip to content

Commit e01424f

Browse files
bvanasscheaxboe
authored andcommitted
mq-deadline: Remove a local variable
Since commit fde0269 ("block: mq-deadline: Remove support for zone write locking"), the local variable 'insert_before' is assigned once and is used once. Hence remove this local variable. Reviewed-by: Damien Le Moal <[email protected]> Cc: Christoph Hellwig <[email protected]> Signed-off-by: Bart Van Assche <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Nitesh Shetty <[email protected]> Reviewed-by: Johannes Thumshirn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent 57e420c commit e01424f

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

block/mq-deadline.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -698,8 +698,6 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq,
698698
list_add(&rq->queuelist, &per_prio->dispatch);
699699
rq->fifo_time = jiffies;
700700
} else {
701-
struct list_head *insert_before;
702-
703701
deadline_add_rq_rb(per_prio, rq);
704702

705703
if (rq_mergeable(rq)) {
@@ -712,8 +710,7 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq,
712710
* set expire time and add to fifo list
713711
*/
714712
rq->fifo_time = jiffies + dd->fifo_expire[data_dir];
715-
insert_before = &per_prio->fifo_list[data_dir];
716-
list_add_tail(&rq->queuelist, insert_before);
713+
list_add_tail(&rq->queuelist, &per_prio->fifo_list[data_dir]);
717714
}
718715
}
719716

0 commit comments

Comments
 (0)