Skip to content

Commit bfa54a7

Browse files
zijun-hugregkh
authored andcommitted
driver core: bus: Fix double free in driver API bus_register()
For bus_register(), any error which happens after kset_register() will cause that @priv are freed twice, fixed by setting @priv with NULL after the first free. Signed-off-by: Zijun Hu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2bdf3b8 commit bfa54a7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/base/bus.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -922,6 +922,8 @@ int bus_register(const struct bus_type *bus)
922922
bus_remove_file(bus, &bus_attr_uevent);
923923
bus_uevent_fail:
924924
kset_unregister(&priv->subsys);
925+
/* Above kset_unregister() will kfree @priv */
926+
priv = NULL;
925927
out:
926928
kfree(priv);
927929
return retval;

0 commit comments

Comments
 (0)